From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH RFC 06/12] mmc: mmci: Add write delay to variant structure. Date: Tue, 22 Apr 2014 09:15:31 +0100 Message-ID: <53562523.7020606@linaro.org> References: <1398116624-31052-1-git-send-email-srinivas.kandagatla@linaro.org> <1398116898-31478-1-git-send-email-srinivas.kandagatla@linaro.org> <20140421220819.GA4468@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140421220819.GA4468@saruman.home> Sender: linux-mmc-owner@vger.kernel.org To: balbi@ti.com Cc: linux-mmc@vger.kernel.org, Russell King , Chris Ball , Ulf Hansson , linux-kernel@vger.kernel.org, agross@quicinc.com, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Thanks Felipe, On 21/04/14 23:08, Felipe Balbi wrote: >> + if (var->reg_write_delay && host->mclk) >> >+ udelay(1 + ((var->reg_write_delay * USEC_PER_SEC)/host->mclk)); > looks like this should be quirk flag instead of a write delay... No > strong feelings though, but it looks like the following would be better, > perhaps: > > if (host_is_qualcom(host)) > udelay(1 + ((3 * USEC_PER_SEC)/host->mclk)); Am ok with your proposal. I was wondering if someone else might need it in future. If not I could change it as you suggested. Thanks, srini > > --