From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Felipe Balbi <balbi@ti.com>, Tim Bird <tbird20d@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Tim Bird <tim.bird@sonymobile.com>
Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller
Date: Wed, 23 Apr 2014 18:09:35 +0400 [thread overview]
Message-ID: <5357C99F.6070009@cogentembedded.com> (raw)
In-Reply-To: <1398261183.4724.226.camel@iivanov-dev>
On 23-04-2014 17:53, Ivan T. Ivanov wrote:
>>>>>> --- a/include/linux/usb/msm_hsusb_hw.h
>>>>>> +++ b/include/linux/usb/msm_hsusb_hw.h
>>>>>> @@ -31,8 +31,9 @@
>>>>>> #define USB_USBINTR (MSM_USB_BASE + 0x0148)
>>>>>>
>>>>>> #define PORTSC_PHCD (1 << 23) /* phy suspend mode */
>>>>>> -#define PORTSC_PTS_MASK (3 << 30)
>>>>>> -#define PORTSC_PTS_ULPI (3 << 30)
>>>>>> +#define PORTSC_PTS_MASK (3 << 30)
>>>>>> +#define PORTSC_PTS_ULPI (2 << 30)
>>>>>> +#define PORTSC_PTS_SERIAL (3 << 30)
>>>>> Please use tabs, not spaces here.
>>>> Thanks, will fix and resend.
>>> I answered too quickly. File contain tabs and spaces for
>>> indentation of definitions.
>> You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces?
> In this particular hunk, original code uses spaces.
That I saw. 8-)
I was asking about this file in general.
> Ivan
>>> Should I still use tabs here?
>> If they are already used, why not?
>>> Regards,
>>> Ivan
WBR, Sergei
next prev parent reply other threads:[~2014-04-23 14:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 9:20 [PATCH v6 00/19] usb: phy: msm: Fixes, cleanups and DT support Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM Ivan T. Ivanov
[not found] ` <1398158438-21579-2-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-04-22 14:57 ` Felipe Balbi
2014-04-22 15:16 ` Ivan T. Ivanov
2014-04-22 15:24 ` Felipe Balbi
[not found] ` <20140422152425.GL5524-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-04-23 8:48 ` Ivan T. Ivanov
2014-04-23 15:02 ` Felipe Balbi
2014-04-22 9:20 ` [PATCH v6 02/19] usb: phy: msm: Remove __init macro from driver probe method Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 06/19] usb: phy: msm: Fix checkpatch.pl warnings Ivan T. Ivanov
2014-04-22 15:30 ` Srinivas Kandagatla
2014-04-23 6:51 ` Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 07/19] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 08/19] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 10/19] usb: phy: msm: Properly check result from platform_get_irq() Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 11/19] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov
[not found] ` <1398158438-21579-12-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-04-22 16:05 ` Srinivas Kandagatla
2014-04-23 7:48 ` Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 12/19] usb: phy: msm: Use reset framework for LINK and PHY resets Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 13/19] usb: phy: msm: Add support for secondary PHY control Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 14/19] usb: phy: msm: Correct USB PHY Reset sequence for newer platform Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller Ivan T. Ivanov
[not found] ` <1398158438-21579-16-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-04-22 13:09 ` Sergei Shtylyov
2014-04-23 13:24 ` Ivan T. Ivanov
2014-04-23 13:35 ` Ivan T. Ivanov
2014-04-23 13:45 ` Sergei Shtylyov
2014-04-23 13:53 ` Ivan T. Ivanov
2014-04-23 14:09 ` Sergei Shtylyov [this message]
[not found] ` <5357C99F.6070009-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-04-23 14:14 ` Ivan T. Ivanov
2014-04-23 14:31 ` Sergei Shtylyov
2014-04-22 9:20 ` [PATCH v6 17/19] usb: phy: msm: Handle disconnect events Ivan T. Ivanov
[not found] ` <1398158438-21579-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-04-22 9:20 ` [PATCH v6 03/19] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov
2014-04-22 14:57 ` Felipe Balbi
[not found] ` <20140422145745.GJ5524-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-04-22 15:12 ` Ivan T. Ivanov
2014-04-22 15:14 ` Felipe Balbi
2014-04-22 9:20 ` [PATCH v6 04/19] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
[not found] ` <1398158438-21579-5-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-04-22 15:07 ` Srinivas Kandagatla
2014-04-22 15:19 ` Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 05/19] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 09/19] usb: phy: msm: Remove HSUSB prefix from regulator names Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 16/19] usb: phy: msm: Select secondary PHY via TCSR Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 18/19] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX Ivan T. Ivanov
2014-04-22 9:20 ` [PATCH v6 19/19] usb: phy: msm: Use usb_add_phy_dev() to register device Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357C99F.6070009@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tbird20d@gmail.com \
--cc=tim.bird@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).