From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C440FC4332F for ; Sun, 20 Nov 2022 11:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiKTLNL (ORCPT ); Sun, 20 Nov 2022 06:13:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKTLNK (ORCPT ); Sun, 20 Nov 2022 06:13:10 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82BF413F17 for ; Sun, 20 Nov 2022 03:13:09 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id s8so14963762lfc.8 for ; Sun, 20 Nov 2022 03:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=alve7OHoEj+oAIMWnVSIJSVJssYyKDfSkrERnLfRn3c=; b=ADlV0sA5wH6pYEVrFxQJp32Ub04pNF9GdIVkruPcdY/FoVnvjqhCGuz8dcRhgFvYTd D7G2wHTAJASk4TE3sHuNA26HKx9YkS9DAeVR/LiB6fg3iA/p6trWHuZjBn2V7JqCNuaf LzOhXGVhU6eZsR55y6wT//Yy9iv7Q1JPjLOMKalKhlljgCnPRxa8TIxWpYbzsR7L05Xm HHxFz9xTmCeJw8/d9n/l7HtUvvi7O0bw9vYD+Guiwn9ZlKdYbsnxTp85+3jN5JDw6eHX VpWYhgiKp3zQHFuLVpj7Zm1sU0VSBa7Na9LKgKaZb4LbJj7xn9/0Emopi7LMtimrpAtZ YHiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=alve7OHoEj+oAIMWnVSIJSVJssYyKDfSkrERnLfRn3c=; b=SZLnt+cbo772wqsfW61VPpYevMJtn4q7I9FhynQOsp6oAsMjB7PjkgeD1PDirZL+2m m7OSyFDayaFjUn299k7SxXlR/PDhRLkb2eCr3UypRFs6hDqP5MVPH6SH7EtB75qKR1/j JIeWSJ2qhFnmEGaBsBCEmdPQCN6nFzBAsL3oQfNrpQaWagPK2hiSJZVa6m3e4RqwuZTp RhIobBInhiM1Vr/uiv0hy3rBnvvmpjc7bYc5Ap3FHr8EJAXz8yKSh1pFpHxbMgBvFpRv 3ljX521YlxCONufXKeECEv4Ep65B8msN3yAiefFrf+p4wcYpbrkPZLsgsxx4XqIVeBY6 cc9g== X-Gm-Message-State: ANoB5pkkRFSf7f99GE9hOz08lAe0A8rCq2LUj3Quta0QHpoAC3vipk/N AKsb3lP7i1c9KQoGFTwo6/iUow== X-Google-Smtp-Source: AA0mqf5dOp8Lvt6U0ZhaQM6camBPTFlNI5YNFSZRECoY6PEDHeq+qXCKta9lNSc9buiu7nNLJXHtsg== X-Received: by 2002:a05:6512:25a8:b0:4aa:a6f8:f042 with SMTP id bf40-20020a05651225a800b004aaa6f8f042mr4250057lfb.405.1668942787798; Sun, 20 Nov 2022 03:13:07 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a26-20020ac25e7a000000b004b4930d53b5sm1499616lfr.134.2022.11.20.03.13.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 03:13:07 -0800 (PST) Message-ID: <536af0d9-aa00-ddf1-753d-670ec2adef91@linaro.org> Date: Sun, 20 Nov 2022 12:13:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices Content-Language: en-US To: Melody Olvera , Andy Gross , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski Cc: Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118182245.31035-1-quic_molvera@quicinc.com> <20221118182245.31035-2-quic_molvera@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221118182245.31035-2-quic_molvera@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18/11/2022 19:22, Melody Olvera wrote: > Add documentation for virtual rpmh devices. These interconnects > are not controlled by the application processor and thus > require separate bindings. Also, move compatibles for sm8450 to > this document and add them for QDU1000/QRU1000 platforms. > > Signed-off-by: Melody Olvera > --- > .../bindings/interconnect/qcom,rpmh-virt.yaml | 55 +++++++++++++++++++ > .../bindings/interconnect/qcom,rpmh.yaml | 2 - > 2 files changed, 55 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml > new file mode 100644 > index 000000000000..5cbaa51df863 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,rpmh-virt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm RPMh Virtual Network-On-Chip Interconnect > + > +maintainers: > + - Georgi Djakov > + - Odelu Kukatla > + > +description: | > + RPMh interconnect providers support system bandwidth requirements through > + RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is > + able to communicate with the BCM through the Resource State Coordinator (RSC) > + associated with each execution environment. Provider nodes must point to at > + least one RPMh device child node pertaining to their RSC and each provider > + can map to multiple RPMh resources. Virtual interconnect providers are not > + controlled by AP and do not support QoS; they should not have associated > + register regions. > + > +allOf: > + - $ref: qcom,rpmh-common.yaml# > + > +properties: > + compatible: > + enum: > + - qcom,qdu1000-clk-virt > + - qcom,qdu1000-mc-virt > + - qcom,sm8450-clk-virt > + - qcom,sm8450-mc-virt You should also move qcom,sdx65-mc-virt, qcom,sc8280xp-mc-virt, qcom,sc8280xp-clk-virt and more. > + > + '#interconnect-cells': true > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + clk_virt: interconnect-0 { > + compatible = "qcom,sm8450-clk-virt"; > + #interconnect-cells = <2>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mc_virt: interconnect-1 { > + compatible = "qcom,sm8450-mc-virt"; > + #interconnect-cells = <2>; > + qcom,bcm-voters = <&apps_bcm_voter>; These are exactly the same examples, so just keep one. Best regards, Krzysztof