From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition. Date: Tue, 13 May 2014 10:33:55 +0100 Message-ID: <5371E703.9050705@linaro.org> References: <1398759492-12970-1-git-send-email-srinivas.kandagatla@linaro.org> <1398759627-13256-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f51.google.com ([74.125.82.51]:54585 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759826AbaEMJeJ (ORCPT ); Tue, 13 May 2014 05:34:09 -0400 Received: by mail-wg0-f51.google.com with SMTP id x13so80103wgg.34 for ; Tue, 13 May 2014 02:34:07 -0700 (PDT) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: Russell King , "linux-mmc@vger.kernel.org" , Chris Ball , Ulf Hansson , "linux-kernel@vger.kernel.org" , agross@quicinc.com, "linux-arm-msm@vger.kernel.org" On 13/05/14 09:08, Linus Walleij wrote: >> > /* Keep ST Micro busy mode if enabled */ >> >- datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE; >> >+ if (host->hw_designer == AMBA_VENDOR_ST) >> >+ datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE; > Do not hard-check the hw_designer everywhere, follow the pattern > if storing special stuff in the variant data. > Got it, I will fix this across other patches too. > struct variant_data { > u32 datactrl_mask_busymode; > (...) > > static struct variant_data variant_u300 = { > .datactrl_mask_busymode = MCI_ST_DPSM_BUSYMODE, > (...) > static struct variant_data variant_nomadik = {