From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID. Date: Wed, 14 May 2014 07:45:33 +0100 Message-ID: <5373110D.2070403@linaro.org> References: <1398759492-12970-1-git-send-email-srinivas.kandagatla@linaro.org> <1398759542-13017-1-git-send-email-srinivas.kandagatla@linaro.org> <5371E8B7.8000103@linaro.org> <20140513221313.GI20486@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f50.google.com ([74.125.82.50]:48495 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbaENGph (ORCPT ); Wed, 14 May 2014 02:45:37 -0400 Received: by mail-wg0-f50.google.com with SMTP id x12so1402145wgg.21 for ; Tue, 13 May 2014 23:45:36 -0700 (PDT) In-Reply-To: <20140513221313.GI20486@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Linus Walleij , Russell King , "linux-mmc@vger.kernel.org" , Chris Ball , Ulf Hansson , "linux-kernel@vger.kernel.org" , agross@quicinc.com, "linux-arm-msm@vger.kernel.org" On 13/05/14 23:13, Stephen Boyd wrote: > On 05/13, Srinivas Kandagatla wrote: >> Thanks Linus W, >> >> On 13/05/14 08:16, Linus Walleij wrote: >>> On Tue, Apr 29, 2014 at 10:19 AM, wrote: >>> >>>> From: Srinivas Kandagatla >>>> >>>> This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci >>>> driver. >>>> >>>> Signed-off-by: Srinivas Kandagatla >>> (...) >>>> + AMBA_VENDOR_QCOM = 0x51, >>> >>> Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention >>> this in the commit message. >>> >> Sounds good, I will fix it in next version and send it to Russell's >> patch tracker. >> > > Please add a note that this id is fake in the commit text or in > the code as well. Sure, I will add it in commit text. >