From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID. Date: Fri, 16 May 2014 09:43:49 -0700 Message-ID: <53764045.5090603@codeaurora.org> References: <1398759492-12970-1-git-send-email-srinivas.kandagatla@linaro.org> <1398759542-13017-1-git-send-email-srinivas.kandagatla@linaro.org> <5371E8B7.8000103@linaro.org> <20140513221313.GI20486@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:51611 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbaEPQnu (ORCPT ); Fri, 16 May 2014 12:43:50 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: Srinivas Kandagatla , Russell King , "linux-mmc@vger.kernel.org" , Chris Ball , Ulf Hansson , "linux-kernel@vger.kernel.org" , agross@quicinc.com, "linux-arm-msm@vger.kernel.org" On 05/16/14 09:24, Linus Walleij wrote: > On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd wrote: > >> Please add a note that this id is fake in the commit text or in >> the code as well. > You just need one of your hardware engineers to add is to one instance > of some test chip round so it exists in any hardware whatsoever and it > is not "fake" anymore... > > This is a bit like device tree, it's defined by the kernel community as much > as by the hardware engineers and it's a little bit of back-and-forth. > Sure, but hardware teams have moved on from this IP so I doubt we can even get them to put it into a test chip. In fact, the devices a generation before the ones Srini is working on (msm8660 for example) have a periph ID of 0x41180 so we need to override that ID in DT with this fake ID for things to even work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation