From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v2 12/14] mmc: mmci: add support for fbclk to latch data and cmd. Date: Fri, 23 May 2014 10:20:38 +0100 Message-ID: <537F12E6.6070809@linaro.org> References: <1400146447-29803-1-git-send-email-srinivas.kandagatla@linaro.org> <1400146669-30302-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:55662 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbaEWJUm (ORCPT ); Fri, 23 May 2014 05:20:42 -0400 Received: by mail-we0-f174.google.com with SMTP id k48so4599991wev.19 for ; Fri, 23 May 2014 02:20:41 -0700 (PDT) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: Russell King , Ulf Hansson , "linux-mmc@vger.kernel.org" , Chris Ball , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" On 23/05/14 10:12, Linus Walleij wrote: > On Thu, May 15, 2014 at 11:37 AM, wrote: > >> From: Srinivas Kandagatla >> >> This patch adds support to fbclk that is used to latch data and >> cmd on some controllers like SD Card controller in Qcom SOC. >> >> Signed-off-by: Srinivas Kandagatla > > (...) > > Isn't this overkill? I totally agree. Initially I did do it the way you suggested, but wanted to be more explicit in what its actually doing and I was also not sure if its Ok to add more than one flag in clkreg_enable. > > @@ -189,6 +192,7 @@ static struct variant_data variant_qcom = { > .clkreg = MCI_CLK_ENABLE, > - .clkreg_enable = MCI_QCOM_CLK_FLOWENA, > + .clkreg_enable = MCI_QCOM_CLK_FLOWENA | > MCI_QCOM_CLK_FEEDBACK_CLK, > .clkreg_8bit_bus_enable = MCI_QCOM_CLK_WIDEBUS_8, > > Isn't this achieveing exactly the same thing without the extra fields? > You unconditionally do it at every enable anyway, don't you? I will fix it and send a new version. Thanks, srini > > Yours, > Linus Walleij >