Re: [Patch v2 3/4] soc: qcom: Add GSBI driver

[Stephen Boyd <sboyd@codeaurora.org>]

On 04/24/14 09:31, Andy Gross wrote:
> +
> +static const struct of_device_id gsbi_dt_match[] = {
> +	{ .compatible = "qcom,gsbi-v1.0.0", },
> +};

Eek. This isn't NULL terminated.


-----8<---

From: Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH] soc: qcom: Terminate gsbi of match table

Failure to terminate this match table can lead to boot failures
depending on where the compiler places the match table.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/soc/qcom/qcom_gsbi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
index 061dd0632dbd..ab7b441c9980 100644
--- a/drivers/soc/qcom/qcom_gsbi.c
+++ b/drivers/soc/qcom/qcom_gsbi.c
@@ -64,6 +64,7 @@ static int gsbi_probe(struct platform_device *pdev)
 
 static const struct of_device_id gsbi_dt_match[] = {
 	{ .compatible = "qcom,gsbi-v1.0.0", },
+	{ }
 };
 
 MODULE_DEVICE_TABLE(of, gsbi_dt_match);

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation