From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v3 03/13] mmc: mmci: Add Qualcomm Id to amba id table Date: Mon, 26 May 2014 18:00:07 +0100 Message-ID: <53837317.9000203@linaro.org> References: <1400849362-7007-1-git-send-email-srinivas.kandagatla@linaro.org> <1400849474-7177-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: Russell King , linux-mmc , Chris Ball , "linux-kernel@vger.kernel.org" , linux-arm-msm@vger.kernel.org, Linus Walleij List-Id: linux-arm-msm@vger.kernel.org Hi Ulf, On 26/05/14 10:10, Ulf Hansson wrote: > Hi Srinivas, > >> >> +static struct variant_data variant_qcom = { >> + .fifosize = 16 * 4, >> + .fifohalfsize = 8 * 4, >> + .clkreg = MCI_CLK_ENABLE, >> + .datalength_bits = 24, >> + .blksz_datactrl4 = true, > > You get compile error here. yes, You are right, I will reorder this patch after the "mmc: mmci: Add Qcom datactrl register variant" Thanks, srini > > Kind regards > Ulf Hansson >