From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Nitin Rawat <quic_nitirawa@quicinc.com>,
andersson@kernel.org, vkoul@kernel.org, agross@kernel.org,
kishon@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org,
Manish Pandey <quic_mapa@quicinc.com>
Subject: Re: [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280
Date: Wed, 16 Aug 2023 20:13:30 +0200 [thread overview]
Message-ID: <538aa051-e263-4ae5-bd32-9e3d106701d8@linaro.org> (raw)
In-Reply-To: <cb1df40a-e879-4095-b5e5-f71a46e92120@linaro.org>
On 16.08.2023 20:12, Konrad Dybcio wrote:
> On 16.08.2023 17:48, Nitin Rawat wrote:
>> Add SC7280 specific register layout and table configs.
>>
>> Co-developed-by: Manish Pandey <quic_mapa@quicinc.com>
>> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>> ---
> Looks very reasonable compared to what I can see downstream.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
I guess one nit I'd add is that having the compatible list sorted
alphanumerically would be a nice touch
Konrad
next prev parent reply other threads:[~2023-08-16 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:48 [PATCH V1 0/2] Add Phy Configuration support for SC7280 Nitin Rawat
2023-08-16 15:48 ` [PATCH V1 1/2] dt-bindings: phy: Add QMP UFS PHY comptible " Nitin Rawat
2023-08-16 20:31 ` Dmitry Baryshkov
2023-08-17 6:49 ` Vinod Koul
2023-08-19 12:05 ` Nitin Rawat
2023-08-18 10:34 ` Krzysztof Kozlowski
2023-08-19 12:03 ` Nitin Rawat
2023-08-16 15:48 ` [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support " Nitin Rawat
2023-08-16 18:12 ` Konrad Dybcio
2023-08-16 18:13 ` Konrad Dybcio [this message]
2023-08-16 20:30 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538aa051-e263-4ae5-bd32-9e3d106701d8@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_mapa@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox