From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28B6C77B7C for ; Fri, 5 May 2023 19:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233262AbjEETOL (ORCPT ); Fri, 5 May 2023 15:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233145AbjEETOJ (ORCPT ); Fri, 5 May 2023 15:14:09 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D23D02269D for ; Fri, 5 May 2023 12:14:06 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ec8149907aso2500668e87.1 for ; Fri, 05 May 2023 12:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683314045; x=1685906045; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5H9rVQL/hXwX4C6YQKIXB1iFe6xi2aNzDtdSIAxJ2gM=; b=UmZCoToMmakn7dH/ICSWg39uBStU5GkZ2U/j94bYpEWR0wo0sJ/Tn7E2bX7lnvq/3F tnfNgUWgX6+jvput1Mktzhi5xsNvxh+8V8L1Nbn/zUOhIuO5wpmOFuxbnPD+yI8PUoRO QWb+pYDJGiNPMtNWhUg8cgDaYj3FC3qmqoyn3IXRAdpSsK3dasXxuo0Cnq7YxSBrnq6W 9/nAVXOcK3MvC1GFw8SS+UEjFOslGOe74ztZYAqkv8zcrmX8opVwWOEFIOxk8XYN16CU YScXIK/KyX+lRcU0uBw/p4chjGUUoohm+x/NJHMa4zZ3cxBf1piIUROEiPgkVF4QJjsh iGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683314045; x=1685906045; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5H9rVQL/hXwX4C6YQKIXB1iFe6xi2aNzDtdSIAxJ2gM=; b=dLnbbwxeNBVGhzF7wW9HtuL5GKN3XVCHyj8BUvAcR8ckhOepNNhEnWZqLDKY3O1zq9 9bKPjmKAHYcGaafEeA1NEEAucKav1qTT6aC4z4i4Q6049Pqsicdyvhhh9Zrsi8APX9sx 3ZkooCNaGexucUixxkzZbAzTF5rsPrce2p4qsuYvhtXWPbkimQkYto8hm1TIhNkOuAyB 64UPEZLKFmmTi4wqxKusjgzp1mhPCbZkxbP/l/h5WBMYK8kbGcEcr3ZgPLqylYPLVTWF H6M3QZswA1koabTg6HGTUOJH3b//15YM5PIC0FFjuA0zrz5UfjrzdH0b2o3fCHlr497g g9mw== X-Gm-Message-State: AC+VfDx62h8uLZd8LGdokWGejZJmK3pjDeb9PpdjWuQchr5Pxsd0aqv8 FQh2zqE1/efuX9FczzZi8zUiGg== X-Google-Smtp-Source: ACHHUZ7YW2zqy886AN83zUF7iGZVZPj2cQtQZFHOjTO95qsoc3txQ7z3DMc2p4uIV0/4y+Dl3W9TGA== X-Received: by 2002:a05:6512:49b:b0:4dc:4b92:dbc4 with SMTP id v27-20020a056512049b00b004dc4b92dbc4mr783194lfq.14.1683314045218; Fri, 05 May 2023 12:14:05 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id q11-20020ac24a6b000000b004f1415aebc4sm384512lfp.255.2023.05.05.12.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 12:14:04 -0700 (PDT) Message-ID: <538f4a97-c9f1-9e27-ef2c-0e2411d4d60d@linaro.org> Date: Fri, 5 May 2023 21:14:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 11/18] media: venus: hfi_venus: Fix version check in venus_cpu_and_video_core_idle() Content-Language: en-US To: Vikash Garodia , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Bryan O'Donoghue , Mansur Alisha Shaik , Jonathan Marek , Hans Verkuil , Dikshita Agarwal Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten References: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> <20230228-topic-venus-v2-11-d95d14949c79@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5.05.2023 15:36, Vikash Garodia wrote: > > On 5/4/2023 1:31 PM, Konrad Dybcio wrote: >> IS_V6() should have instead checked for specific VPU versions. Fix it. > > This is again not a fix. The patch just adds a video hardware AR50_LITE, which is > > not supported on existing driver yet. With existing code, IS_V6 covers the video > > hardwares which are enabled by the driver. ack Konrad > > -Vikash > >> >> Fixes: e396e75fc254 ("media: venus: hfi: Read WRAPPER_TZ_CPU_STATUS_V6 on 6xx") >> Signed-off-by: Konrad Dybcio >> --- >>   drivers/media/platform/qcom/venus/hfi_venus.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c >> index 6d5906fab800..82aa7deeafa1 100644 >> --- a/drivers/media/platform/qcom/venus/hfi_venus.c >> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c >> @@ -1537,7 +1537,7 @@ static bool venus_cpu_and_video_core_idle(struct venus_hfi_device *hdev) >>       void __iomem *cpu_cs_base = hdev->core->cpu_cs_base; >>       u32 ctrl_status, cpu_status; >>   -    if (IS_V6(hdev->core)) >> +    if (IS_AR50_LITE(hdev->core) || IS_IRIS2(hdev->core) || IS_IRIS2_1(hdev->core)) >>           cpu_status = readl(wrapper_tz_base + WRAPPER_TZ_CPU_STATUS_V6); >>       else >>           cpu_status = readl(wrapper_base + WRAPPER_CPU_STATUS); >>