From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole Date: Tue, 17 Jun 2014 14:09:00 -0700 Message-ID: <53A0AE6C.7040706@codeaurora.org> References: <1402410678-12931-1-git-send-email-srinivas.kandagatla@linaro.org> <1402410732-13021-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:35013 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964883AbaFQVJD (ORCPT ); Tue, 17 Jun 2014 17:09:03 -0400 In-Reply-To: <1402410732-13021-1-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, agross@codeaurora.org On 06/10/14 07:32, Srinivas Kandagatla wrote: > The use case is when we boot the platform with bootconsole enabled. What > I noticed is that the console gets locked sometimes up before the bootconsole > is disabled. > > As part of console setup in serial driver it resets that hardware which > is a race condition to bootconsole using the same hardware. This > patch adds a check to see if there is bootconsole before reseting the hardware. > > Am sure there are better ways to solve this, so marking this patch as > RFC. Any suggestions are welcome. > > Isn't there some way to check and wait for the hardware to be unused before we reset it? I recall being able to overcome this "race condition" by removing the printks in the serial driver setup. Does that work for you? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation