From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole Date: Tue, 17 Jun 2014 23:04:29 +0100 Message-ID: <53A0BB6D.1090202@linaro.org> References: <1402410678-12931-1-git-send-email-srinivas.kandagatla@linaro.org> <1402410732-13021-1-git-send-email-srinivas.kandagatla@linaro.org> <53A0AE6C.7040706@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f181.google.com ([74.125.82.181]:49250 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965961AbaFQWEd (ORCPT ); Tue, 17 Jun 2014 18:04:33 -0400 Received: by mail-we0-f181.google.com with SMTP id q59so7713921wes.26 for ; Tue, 17 Jun 2014 15:04:32 -0700 (PDT) In-Reply-To: <53A0AE6C.7040706@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, agross@codeaurora.org On 17/06/14 22:09, Stephen Boyd wrote: > On 06/10/14 07:32, Srinivas Kandagatla wrote: >> The use case is when we boot the platform with bootconsole enabled. What >> I noticed is that the console gets locked sometimes up before the bootconsole >> is disabled. >> >> As part of console setup in serial driver it resets that hardware which >> is a race condition to bootconsole using the same hardware. This >> patch adds a check to see if there is bootconsole before reseting the hardware. >> >> Am sure there are better ways to solve this, so marking this patch as >> RFC. Any suggestions are welcome. >> >> > > Isn't there some way to check and wait for the hardware to be unused > before we reset it? > > I recall being able to overcome this "race condition" by removing the > printks in the serial driver setup. Does that work for you? > Good point, Its possible that removing prints during the transition fixes the issue. I will give it a try.