From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [RFC PATCH 2/2] tty:msm_serial: Do not reset IP if we use bootconsole Date: Thu, 10 Jul 2014 14:38:22 +0100 Message-ID: <53BE974E.6070804@linaro.org> References: <1402410678-12931-1-git-send-email-srinivas.kandagatla@linaro.org> <1402410732-13021-1-git-send-email-srinivas.kandagatla@linaro.org> <53A0AE6C.7040706@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f171.google.com ([74.125.82.171]:51772 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbaGJNiZ (ORCPT ); Thu, 10 Jul 2014 09:38:25 -0400 Received: by mail-we0-f171.google.com with SMTP id q58so9108251wes.2 for ; Thu, 10 Jul 2014 06:38:24 -0700 (PDT) In-Reply-To: <53A0AE6C.7040706@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, agross@codeaurora.org Hi Stephen, Did bit more testing on this. I could not reproduce this issue (across 40+ reboots) once I removed some of my debug, so we can ignore this patch for now, But we still need gsbi patch for clock. Thanks, srini On 17/06/14 22:09, Stephen Boyd wrote: > On 06/10/14 07:32, Srinivas Kandagatla wrote: >> The use case is when we boot the platform with bootconsole enabled. What >> I noticed is that the console gets locked sometimes up before the bootconsole >> is disabled. >> >> As part of console setup in serial driver it resets that hardware which >> is a race condition to bootconsole using the same hardware. This >> patch adds a check to see if there is bootconsole before reseting the hardware. >> >> Am sure there are better ways to solve this, so marking this patch as >> RFC. Any suggestions are welcome. >> >> > > Isn't there some way to check and wait for the hardware to be unused > before we reset it? > > I recall being able to overcome this "race condition" by removing the > printks in the serial driver setup. Does that work for you? >