From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Pramod Gurav <pramod.gurav@smartplayin.com>
Cc: pramod.gurav.etc@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Josh Cartwright <joshc@codeaurora.org>,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected
Date: Wed, 16 Jul 2014 16:53:41 +0300 [thread overview]
Message-ID: <53C683E5.90604@mm-sol.com> (raw)
In-Reply-To: <1405515375.452411340@apps.rackspace.com>
<snip>
>
> Thanks.
> I misunderstood the Kconfig documentation which says, "Reverse dependencies can only be used with boolean or tristate symbols". In the note following this statement doc says, "In general use select only for non-visible symbols".
>
> The CONFIG_SPMI option is visible in menuconfig hence either it should be set by default in multi_v7_defconfig(like in qcom_defconfig) or driver owner should mention a 'depneds on CONFIG_SPMI' as suggested by Lars-Peter Clausen.
> I prefer the former (defconfig).
>
> Shall I send a new patch adding it in multi_v7_defconfig?
yes, I think it should be enabled. On the other side I'm not sure that
it will be acceptable because presently there are no users if it in
multi platform build. Might be worth to do it ones the MFD driver is in.
And I/we should add a dependency to SPMI in the MFD driver as Lars
pointed out.
--
regards,
Stan
next prev parent reply other threads:[~2014-07-16 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 11:39 [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected pramod.gurav.etc
2014-07-16 12:07 ` Stanimir Varbanov
2014-07-16 12:14 ` Pramod Gurav
2014-07-16 12:25 ` Stanimir Varbanov
2014-07-16 12:56 ` Pramod Gurav
2014-07-16 13:53 ` Stanimir Varbanov [this message]
2014-07-16 13:53 ` Mark Brown
2014-07-16 14:00 ` Ivan T. Ivanov
2014-07-16 14:18 ` Mark Brown
2014-07-16 14:42 ` pramod gurav
2014-07-16 14:48 ` Mark Brown
2014-07-16 12:19 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C683E5.90604@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=broonie@linaro.org \
--cc=joshc@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.gurav.etc@gmail.com \
--cc=pramod.gurav@smartplayin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).