Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional.

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 17/07/14 13:54, pramod gurav wrote:
> Hi Srini,
>
> On Thu, Jul 17, 2014 at 6:19 PM,  <pramod.gurav.etc@gmail.com> wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> This patch makes the phy reset clk and reset line optional as this clk
>> is not available on boards like IFC6410 with APQ8064.
>>
> .
> [snip]
> .
>>
>>          pdata->mode = of_usb_get_dr_mode(node);
>>          if (pdata->mode == USB_DR_MODE_UNKNOWN)
>> @@ -1556,7 +1556,7 @@ static int msm_otg_probe(struct platform_device *pdev)
>>                                             np ? "phy" : "usb_phy_clk");
>>          if (IS_ERR(motg->phy_reset_clk)) {
>>                  dev_err(&pdev->dev, "failed to get usb_phy_clk\n");
>
> I keep getting this error on IFC6410. Cant we suppress it?
IMO, We should ignore this message for IFC 6410 board as they do not 
have phy reset clk.


>
>> -               return PTR_ERR(motg->phy_reset_clk);
>> +               motg->phy_reset_clk = NULL;
>
> for non-ifc boards(having this clk), if they have this clock should
> not code return on failure to get the usb_phy_clk?
I agree, Its a catch 22 situation here.
Unless we introduce more SOC level awareness into this driver. Which 
would be a bit overdo for printing this message.

The error message should be considered more seriously for non IFC board.

Thanks,
srini
>
>>          }
>>
>>          motg->clk = devm_clk_get(&pdev->dev, np ? "core" : "usb_hs_clk");
>> --
>> 1.7.9.5
>>
>
>
>