From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional. Date: Thu, 17 Jul 2014 14:14:15 +0100 Message-ID: <53C7CC27.9010106@linaro.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com ([74.125.82.177]:53164 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756744AbaGQNOS (ORCPT ); Thu, 17 Jul 2014 09:14:18 -0400 Received: by mail-we0-f177.google.com with SMTP id w62so2931255wes.22 for ; Thu, 17 Jul 2014 06:14:17 -0700 (PDT) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: pramod gurav Cc: linux-usb@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org On 17/07/14 13:54, pramod gurav wrote: > Hi Srini, > > On Thu, Jul 17, 2014 at 6:19 PM, wrote: >> From: Srinivas Kandagatla >> >> This patch makes the phy reset clk and reset line optional as this clk >> is not available on boards like IFC6410 with APQ8064. >> > . > [snip] > . >> >> pdata->mode = of_usb_get_dr_mode(node); >> if (pdata->mode == USB_DR_MODE_UNKNOWN) >> @@ -1556,7 +1556,7 @@ static int msm_otg_probe(struct platform_device *pdev) >> np ? "phy" : "usb_phy_clk"); >> if (IS_ERR(motg->phy_reset_clk)) { >> dev_err(&pdev->dev, "failed to get usb_phy_clk\n"); > > I keep getting this error on IFC6410. Cant we suppress it? IMO, We should ignore this message for IFC 6410 board as they do not have phy reset clk. > >> - return PTR_ERR(motg->phy_reset_clk); >> + motg->phy_reset_clk = NULL; > > for non-ifc boards(having this clk), if they have this clock should > not code return on failure to get the usb_phy_clk? I agree, Its a catch 22 situation here. Unless we introduce more SOC level awareness into this driver. Which would be a bit overdo for printing this message. The error message should be considered more seriously for non IFC board. Thanks, srini > >> } >> >> motg->clk = devm_clk_get(&pdev->dev, np ? "core" : "usb_hs_clk"); >> -- >> 1.7.9.5 >> > > >