From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional. Date: Thu, 17 Jul 2014 15:41:05 +0100 Message-ID: <53C7E081.303@linaro.org> References: <53C7CC27.9010106@linaro.org> <20140717143941.GB10459@saruman.home> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140717143941.GB10459-HgARHv6XitL9zxVx7UNMDg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: pramod gurav , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On 17/07/14 15:39, Felipe Balbi wrote: > Hi, > > On Thu, Jul 17, 2014 at 02:14:15PM +0100, Srinivas Kandagatla wrote: >> On 17/07/14 13:54, pramod gurav wrote: >>> Hi Srini, >>> >>> On Thu, Jul 17, 2014 at 6:19 PM, wrote: >>>> From: Srinivas Kandagatla >>>> >>>> This patch makes the phy reset clk and reset line optional as this clk >>>> is not available on boards like IFC6410 with APQ8064. >>>> >>> . >>> [snip] >>> . >>>> >>>> pdata->mode = of_usb_get_dr_mode(node); >>>> if (pdata->mode == USB_DR_MODE_UNKNOWN) >>>> @@ -1556,7 +1556,7 @@ static int msm_otg_probe(struct platform_device *pdev) >>>> np ? "phy" : "usb_phy_clk"); >>>> if (IS_ERR(motg->phy_reset_clk)) { >>>> dev_err(&pdev->dev, "failed to get usb_phy_clk\n"); >>> >>> I keep getting this error on IFC6410. Cant we suppress it? >> IMO, We should ignore this message for IFC 6410 board as they do not have >> phy reset clk. > > looks like that should become a dev_dbg() then ? > Sure, I agree. I will resend the patch with dev_dbg. --srini -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html