From: Stephen Boyd <sboyd@codeaurora.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
shawn.guo@linaro.org, linux-arm-msm@vger.kernel.org,
spk.linux@gmail.com, thomas.ab@samsung.com, t.figa@samsung.com,
santosh.shilimkar@ti.com, thomas.petazzoni@free-electrons.com,
pramod.gurav@smartplayin.com
Subject: Re: [PATCH V3 09/10] cpufreq: cpu0: rename driver and internals to 'cpufreq_generic'
Date: Mon, 08 Sep 2014 16:18:11 -0700 [thread overview]
Message-ID: <540E3933.8000904@codeaurora.org> (raw)
In-Reply-To: <1841344.yBggYEARvr@vostro.rjw.lan>
On 09/08/14 16:34, Rafael J. Wysocki wrote:
> On Thursday, August 28, 2014 11:22:31 AM Viresh Kumar wrote:
>> The naming convention of this driver was always under the scanner, people
>> complained that it should have a more generic name than cpu0, as it manages all
>> CPUs that are sharing clock lines.
>>
>> Also, in future it will be modified to support any number of clusters with
>> separate clock/voltage lines.
>>
>> Lets rename it to 'cpufreq_generic' from 'cpufreq_cpu0'.
> I'm not a big fan of changes like this to be honest, because they kind of
> hide history. For example, if you do a "git blame" on the new file, it will
> show your commit and nothing before it.
Sounds like a tooling problem. But git blame doesn't have that behavior
so there isn't actually any problem?
$ git blame -- drivers/cpufreq/cpufreq-generic.c | head -10
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 1) /*
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 2) * Copyright (C) 2012 Freescale Semiconductor, Inc.
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 3) *
da1a765bf681c drivers/cpufreq/cpufreq-cpu0.c (Viresh Kumar 2014-06-30 10:15:22 +0530 4) * Copyright (C) 2014 Linaro.
da1a765bf681c drivers/cpufreq/cpufreq-cpu0.c (Viresh Kumar 2014-06-30 10:15:22 +0530 5) * Viresh Kumar <viresh.kumar@linaro.org>
da1a765bf681c drivers/cpufreq/cpufreq-cpu0.c (Viresh Kumar 2014-06-30 10:15:22 +0530 6) *
ac4f646b8a5f3 drivers/cpufreq/cpufreq-generic.c (Viresh Kumar 2014-06-27 10:58:51 +0530 7) * The OPP code in function set_target() is reused from
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 8) * drivers/cpufreq/omap-cpufreq.c
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 9) *
95ceafd46359d drivers/cpufreq/cpufreq-cpu0.c (Shawn Guo 2012-09-06 07:09:11 +0000 10) * This program is free software; you can redistribute it and/or modify
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-09-08 23:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 5:52 [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 01/10] cpufreq: Add support for per-policy driver data Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 02/10] cpufreq: cpu0: Update Module Author Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 03/10] cpufreq: cpu0: don't validate clock on clk_put() Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 04/10] cpufreq: cpu0: print relevant error when we defer probe Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 05/10] cpufreq: cpu0: use dev_{err|warn|dbg} instead of pr_{err|warn|debug} Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 06/10] cpufreq: cpu0: Move per-cluster initialization code to ->init() Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 07/10] cpufreq: cpu0: try regulators with name "cpu-supply" Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 08/10] cpufreq: cpu0: Make allocate_resources() work for any CPU Viresh Kumar
2014-08-28 5:52 ` [PATCH V3 09/10] cpufreq: cpu0: rename driver and internals to 'cpufreq_generic' Viresh Kumar
2014-09-08 23:34 ` Rafael J. Wysocki
2014-09-08 23:18 ` Stephen Boyd [this message]
2014-09-08 23:39 ` Rafael J. Wysocki
2014-09-08 23:52 ` Rafael J. Wysocki
2014-09-09 0:01 ` Stephen Boyd
2014-09-09 4:47 ` Viresh Kumar
2014-09-09 13:29 ` Rafael J. Wysocki
2014-09-09 13:52 ` Viresh Kumar
2014-09-09 0:02 ` Rafael J. Wysocki
2014-08-28 5:52 ` [PATCH V3 10/10] cpufreq: generic: set platform_{driver|device} '.name' to 'cpufreq-generic' Viresh Kumar
2014-08-28 14:16 ` [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Santosh Shilimkar
2014-09-01 6:40 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E3933.8000904@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=shawn.guo@linaro.org \
--cc=spk.linux@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).