From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v1] soc: qcom: do not disable the iface clock in probe Date: Tue, 23 Sep 2014 19:41:11 +0100 Message-ID: <5421BEC7.60003@linaro.org> References: <1408081268-5748-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f52.google.com ([74.125.82.52]:53450 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbaIWSlO (ORCPT ); Tue, 23 Sep 2014 14:41:14 -0400 Received: by mail-wg0-f52.google.com with SMTP id n12so3270691wgh.35 for ; Tue, 23 Sep 2014 11:41:13 -0700 (PDT) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kumar Gala Cc: Andy Gross , linux-arm-msm , arm@kernel.org, Kevin Hilman , linux-arm-kernel@lists.infradead.org On 23/09/14 18:42, Kumar Gala wrote: > > On Aug 15, 2014, at 12:41 AM, Srinivas Kandagatla wrote: > >> The use case here is when we have a bootconsole which is printing the >> characters on serial console and gsbi driver comes up after some time. >> As gsbi driver disables the clock in probe the bootconsole locks up. >> >> This patch fixes the problem by disabling the clock in platform remove >> rather than in probe. >> >> Tested-by: Linus Walleij >> Signed-off-by: Srinivas Kandagatla >> --- >> Changes since RFC: >> - none, just a subject line change. > > Srini, > > We need some changes to the commit message for this to get into v3.17. > Sure.. I will send v2 with change log referring to http://www.spinics.net/lists/linux-arm-msm/msg10589.html --srini > Probably some references to: > > http://www.spinics.net/lists/linux-arm-msm/msg10589.html > > Adding Kevin to provide details on what else should be in commit message w/regards to the regression we introduced. > > - k >