From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [RFC/PATCH 1/5] mtd: ubi: Read disturb infrastructure Date: Sun, 28 Sep 2014 10:54:48 +0200 Message-ID: <5427CCD8.2090605@nod.at> References: <1411886220-8208-1-git-send-email-tlinder@codeaurora.org> <5427C45C.2080506@nod.at> <5427CB6E.7010007@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549AbaI1Iyv (ORCPT ); Sun, 28 Sep 2014 04:54:51 -0400 In-Reply-To: <5427CB6E.7010007@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Tanya Brokhman , dedeking1@gmail.com Cc: Artem Bityutskiy , linux-arm-msm@vger.kernel.org, open list , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse Am 28.09.2014 10:48, schrieb Tanya Brokhman: >>> @@ -424,6 +440,8 @@ struct ubi_fm_sb { >>> __be32 used_blocks; >>> __be32 block_loc[UBI_FM_MAX_BLOCKS]; >>> __be32 block_ec[UBI_FM_MAX_BLOCKS]; >>> + __be32 block_rc[UBI_FM_MAX_BLOCKS]; >>> + __be64 block_let[UBI_FM_MAX_BLOCKS]; >> >> Doesn't this break the fastmap on-disk layout? > > What do you mean "break"? I verified fastmap feature is working. the whole read-disturb depends on it so I tested this thoroughly. Did you write a fastmap with your changes applied and then an attach using a fastmap implementation *without* you changes? I bet it will not work because the disk layout is now different. Linux is not the only user of fastmap. We need to be very careful here. Thanks, //richard