From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH] iio: inkern: Add of_xlate function to struct iio_dev Date: Sat, 18 Oct 2014 13:14:16 +0100 Message-ID: <54425998.7060808@kernel.org> References: <1412253128-32165-1-git-send-email-iivanov@mm-sol.com> <5442522D.40203@kernel.org> <544253F3.9060002@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <544253F3.9060002-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen , "Ivan T. Ivanov" Cc: Sachin Kamat , Srinivas Pandruvada , John Stultz , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On 18/10/14 12:50, Lars-Peter Clausen wrote: > On 10/18/2014 01:42 PM, Jonathan Cameron wrote: >> On 02/10/14 13:32, Ivan T. Ivanov wrote: >>> When #iio-cells is greater than '0', the driver could provide >>> a custom of_xlate function that reads the *args* and returns >>> the appropriate index in registered IIO channels array. >>> >>> Add simple translation function, suitable for the most 1:1 >>> mapped channels in IIO chips, and use it when driver did not >>> provide custom implementation. >>> >>> Signed-off-by: Ivan T. Ivanov >> Any more comments on this? Been sat a while and the discussions seems >> to have died out. >> >> As Ivan has pointed out, very similar approaches are used >> elsewhere (gpio for example). > > Looks good to me: > > Reviewed-by: Lars-Peter Clausen > > When we initially added the DT support to IIO I was hoping that we can get away > with just using the simple and generic xlate function for all devices. But it > looks as if some more complex devices need to overwrite it. We should be careful > about adding new driver specific xlate implementations and make sure that it is > actually needed. > > One thing we might want to consider though is instead of adding the xlate > callback to the iio_dev struct add it to the iio_info struct since it should be > the same for different device instances of the same driver. And this is also > where all the other callbacks are. Good point - would definitely prefer that. J > > - Lars