From: Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] soc: qcom: pmic_glink: Add charger PDR service path and service name to client data
Date: Tue, 28 Oct 2025 16:30:28 -0700 [thread overview]
Message-ID: <54602e66-4692-409b-b520-2f880e0c3dd3@oss.qualcomm.com> (raw)
In-Reply-To: <5uyhz4uv7ccsj7cevimqrsoywne6f5ax5j2t4uosz6a7due4ac@3x4ouutt5nwy>
On 10/28/2025 10:20 AM, Abel Vesa wrote:
> On 25-10-27 14:22:50, Anjelique Melendez wrote:
>> - goto out_release_aux_devices;
>> + if (pg->data->charger_pdr_service_name && pg->data->charger_pdr_service_path) {
>> + service = pdr_add_lookup(pg->pdr, pg->data->charger_pdr_service_name,
>> + pg->data->charger_pdr_service_path);
>> + if (IS_ERR(service)) {
>> + ret = dev_err_probe(&pdev->dev, PTR_ERR(service),
>> + "failed adding pdr lookup for charger_pd\n");
>> + goto out_release_aux_devices;
>> + }
>> }
>
> But this does nothing on Kaanapali and Glymur. Am I wrong?
>
> Yes, you do not have a charger PD on Glymur, but you do have an ssr,
> for which you do need to register a notifier instead.
>
> You need to be doing something like this:
> https://gitlab.com/Linaro/arm64-laptops/linux/-/commit/2cd84e303d263d8fd5de3730714a16c29cc6788b
Please take a look at this change, just applied:
https://lore.kernel.org/all/20250919175025.2988948-1-anjelique.melendez@oss.qualcomm.com/.
next prev parent reply other threads:[~2025-10-28 23:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 21:22 [PATCH v2 0/2] soc: qcom: pmic_glink: Add support for battery management running on SOCCP Anjelique Melendez
2025-10-27 21:22 ` [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add Kaanapali and Glymur compatibles Anjelique Melendez
2025-10-28 3:58 ` Bjorn Andersson
2025-10-28 8:29 ` Krzysztof Kozlowski
2025-10-28 8:36 ` Krzysztof Kozlowski
2025-10-28 9:04 ` Konrad Dybcio
2025-10-28 9:16 ` Krzysztof Kozlowski
2025-10-28 9:19 ` Konrad Dybcio
2025-10-28 9:21 ` Krzysztof Kozlowski
2025-10-28 9:30 ` Krzysztof Kozlowski
2025-10-28 22:55 ` Anjelique Melendez
2025-10-29 5:26 ` Krzysztof Kozlowski
2025-10-28 14:14 ` Bjorn Andersson
2025-11-05 13:07 ` Kamal Wadhwa
2025-10-27 21:22 ` [PATCH v2 2/2] soc: qcom: pmic_glink: Add charger PDR service path and service name to client data Anjelique Melendez
2025-10-28 9:22 ` Konrad Dybcio
2025-10-28 17:20 ` Abel Vesa
2025-10-28 23:30 ` Anjelique Melendez [this message]
2025-10-29 8:41 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54602e66-4692-409b-b520-2f880e0c3dd3@oss.qualcomm.com \
--to=anjelique.melendez@oss.qualcomm.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox