From: "Dorfman, Konstantin" <kdorfman@codeaurora.org>
To: Sujit Reddy Thumma <sthumma@codeaurora.org>, linux-mmc@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/5] mmc: core: Add support to read command queue parameters
Date: Thu, 04 Dec 2014 14:27:01 -0800 [thread overview]
Message-ID: <5480DFB5.5000104@codeaurora.org> (raw)
In-Reply-To: <20141202115629.GA27638@asutoshd-ics.in.qualcomm.com>
On 12/2/2014 3:56 AM, Sujit Reddy Thumma wrote:
> eMMC cards with EXT_CSD version >= 7, optionally support command
> queuing feature as defined by Jedec eMMC5.1. Add support for probing
> command queue feature for such type of cards.
>
> Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
> drivers/mmc/core/mmc.c | 15 +++++++++++++++
> include/linux/mmc/card.h | 7 +++++++
> include/linux/mmc/mmc.h | 6 ++++++
> 3 files changed, 28 insertions(+)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 1ab5f3a..0ef3af5 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -571,6 +571,21 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
> card->ext_csd.data_sector_size = 512;
> }
>
> + if (card->ext_csd.rev >= 7) {
> + card->ext_csd.cmdq_support = ext_csd[EXT_CSD_CMDQ_SUPPORT];
> + if (card->ext_csd.cmdq_support)
> + card->ext_csd.cmdq_depth = ext_csd[EXT_CSD_CMDQ_DEPTH];
> + }
Remove duplicated code.
> +
> + if (card->ext_csd.rev >= 7) {
> + card->ext_csd.cmdq_support = ext_csd[EXT_CSD_CMDQ_SUPPORT];
> + if (card->ext_csd.cmdq_support)
> + card->ext_csd.cmdq_depth = ext_csd[EXT_CSD_CMDQ_DEPTH];
From the spec (7.4.19 CMDQ_DEPTH [307]) [4:0]: N, a parameter used to
calculate the Queue Depth of task queue in the device. Queue Depth = N+1.
next prev parent reply other threads:[~2014-12-04 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 11:56 [PATCH 1/5] mmc: core: Add support to read command queue parameters Sujit Reddy Thumma
2014-12-04 22:27 ` Dorfman, Konstantin [this message]
2015-01-15 9:10 ` Ulf Hansson
2015-01-16 3:32 ` Asutosh Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480DFB5.5000104@codeaurora.org \
--to=kdorfman@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sthumma@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox