From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x
Date: Thu, 29 Jan 2015 14:21:13 -0800
Message-ID: <54CAB259.8090704@codeaurora.org>
References: <1421419702-17812-1-git-send-email-architt@codeaurora.org> <1421419702-17812-2-git-send-email-architt@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1421419702-17812-2-git-send-email-architt@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Archit Taneja <architt@codeaurora.org>, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, agross@codeaurora.org, galak@codeaurora.org
List-Id: linux-arm-msm@vger.kernel.org

On 01/16/15 06:48, Archit Taneja wrote:
> +
> +static struct clk_branch ebi2_aon_clk = {
> +	.hwcg_reg = 0x3b00,
> +	.hwcg_bit = 6,

It looks like these bits only apply to ebi2_clk, and not ebi2_aon_clk,
so these two lines should be dropped.

> +	.halt_reg = 0x2fcc,
> +	.halt_bit = 0,
> +	.clkr = {
> +		.enable_reg = 0x3b00,
> +		.enable_mask = BIT(8),
> +		.hw.init = &(struct clk_init_data){
> +			.name = "ebi2_always_on_clk",
> +			.ops = &clk_branch_ops,
> +			.flags = CLK_IS_ROOT,
> +		},
> +	},
> +};
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project