From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 5/6] drm/imx: Remove local fbdev emulation Kconfig option Date: Wed, 11 Mar 2015 10:23:47 +0530 Message-ID: <54FFCA5B.3010401@codeaurora.org> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-6-git-send-email-architt@codeaurora.org> <1425984858.3141.37.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38484 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbbCKEx4 (ORCPT ); Wed, 11 Mar 2015 00:53:56 -0400 In-Reply-To: <1425984858.3141.37.camel@pengutronix.de> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Philipp Zabel Cc: daniel.vetter@ffwll.ch, robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org On 03/10/2015 04:24 PM, Philipp Zabel wrote: > Hi Archit, > > thanks for the cleanup! > > Am Dienstag, den 10.03.2015, 15:11 +0530 schrieb Archit Taneja: >> DRM_IMX_FB_HELPER config is currently used to enable/disable fbdev emulation for >> the imx kms driver. >> >> Remove this local config option and use the top level DRM_FBDEV_EMULATION config >> option where applicable. Using this config lets us also prevent wrapping around >> drm_fb_helper_* calls with #ifdefs in certain places. >> >> We replace the #ifdef in imx_drm_driver_load with CONFIG_DRM_FBDEV_EMULATION. >> It's probably okay to get remove the #ifdef itself, but just left it here for >> now to be safe. It can be removed after some testing. >> >> Signed-off-by: Archit Taneja > > Tested-by: Philipp Zabel > (Both with and without the #ifdef CONFIG_DRM_FBDEV_EMULATION removed.) > Thanks for testing it out. > Although this is for another patch, I think the legacyfb_depth > module_param should be removed altogether if CONFIG_DRM_FBDEV_EMULATION > is disabled, so maybe that #ifdef should stay. I'll create a patch for that for future revs of this patch set. Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project