From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 1/6] drm: Add top level Kconfig option for DRM fbdev emulation Date: Wed, 11 Mar 2015 10:27:26 +0530 Message-ID: <54FFCB36.1050904@codeaurora.org> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1425980493-27533-2-git-send-email-architt@codeaurora.org> <20150310094756.GE3800@phenom.ffwll.local> <54FEBEF1.5000103@codeaurora.org> <20150310100547.GG3800@phenom.ffwll.local> <54FEC5F1.90208@codeaurora.org> <87zj7krhom.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38598 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbbCKE5e (ORCPT ); Wed, 11 Mar 2015 00:57:34 -0400 In-Reply-To: <87zj7krhom.fsf@intel.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jani Nikula , robdclark@gmail.com, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel@ffwll.ch On 03/10/2015 09:03 PM, Jani Nikula wrote: > On Tue, 10 Mar 2015, Archit Taneja wrote: >> On 03/10/2015 03:35 PM, Daniel Vetter wrote: >>> On Tue, Mar 10, 2015 at 03:22:49PM +0530, Archit Taneja wrote: >>>> >>>> >>>> On 03/10/2015 03:17 PM, Daniel Vetter wrote: >>>>> On Tue, Mar 10, 2015 at 03:11:28PM +0530, Archit Taneja wrote: >>>> DRM_KMS_FB_HELPER selects that for us, right? >>> >>> Hm right I've missed that. Reminds me that you need one more patch at the >>> end to remove all the various select DRM_KMS_FB_HELPER from all drm >>> drivers. Otherwise this knob here won't work by default if you e.g. select >>> radeon. In general we can't mix explicit options with menu entries with a >>> select. >> >> I was trying that out. Removing DRM_KMS_FB_HELPER and having >> DRM_FBDEV_EMULATION disabled breaks drivers which use FB stuff >> internally in their respective xyz_fbdev.c files. >> >> Are you saying that we should remove DRM_KMS_FB_HELPER for such drivers >> and replace them with 'select DRM_FBDEV_EMULATION'? > > Slightly tangential: As a rule of thumb, you should not "select" > anything that is visible in menuconfig or has dependencies [1]. This > will break the build eventually, and attempts to fix it are troublesome > [2]. Thanks, I'll keep this in mind! Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project