From mboxrd@z Thu Jan  1 00:00:00 1970
From: Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH 4/5] clk: qcom: Add A53 clock driver
Date: Mon, 15 Jun 2015 18:36:11 +0300
Message-ID: <557EF0EB.9040403@linaro.org>
References: <1434098519-26406-1-git-send-email-georgi.djakov@linaro.org>	 <1434098519-26406-5-git-send-email-georgi.djakov@linaro.org> <1434376712.2069.5.camel@x220>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-wi0-f174.google.com ([209.85.212.174]:37969 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754213AbbFOPgO (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Mon, 15 Jun 2015 11:36:14 -0400
Received: by wibdq8 with SMTP id dq8so82614640wib.1
        for <linux-arm-msm@vger.kernel.org>; Mon, 15 Jun 2015 08:36:13 -0700 (PDT)
In-Reply-To: <1434376712.2069.5.camel@x220>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Paul Bolle <pebolle@tiscali.nl>
Cc: sboyd@codeaurora.org, agross@codeaurora.org, mturquette@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org

On 06/15/2015 04:58 PM, Paul Bolle wrote:
> On Fri, 2015-06-12 at 11:41 +0300, Georgi Djakov wrote:
>> --- /dev/null
>> +++ b/drivers/clk/qcom/clk-a53.c
> 
>> +static int __init qcom_a53_init(void)
>> +{
>> +	return platform_driver_register(&qcom_a53_driver);
>> +}
>> +arch_initcall(qcom_a53_init);
> 
> There's no function that's, well, called by module_exit() that undoes
> the above. So one can build this as a module, load that module, but not
> unload it. That's by design?
> 
> 

In general, it is not expected to unload it as this is for the
main CPU clock, but i will add a module_exit() call to make it
correct. Thanks for the comment!

BR,
Georgi