From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Date: Mon, 13 Jul 2015 16:05:49 +0200 Message-ID: <55A3C5BD.5060505@vodafone.de> References: <38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0542438055==" Return-path: In-Reply-To: <38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Koenig, Christian" , Archit Taneja Cc: "Deucher, Alexander" , "linux-arm-msm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: linux-arm-msm@vger.kernel.org This is a multi-part message in MIME format. --===============0542438055== Content-Type: multipart/alternative; boundary="------------020507020007030700070603" This is a multi-part message in MIME format. --------------020507020007030700070603 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Please completely ignore that mail, my fatty fingers have selected the=20 wrong mail for replying. Regards, Christian. On 13.07.2015 09:08, Koenig, Christian wrote: > > Hi Jammy, > > I suggested to make the feature optional because of the unit test's. > > There we don't need this feature and actually want to test the kernel=20 > functionality. > > Regards, > Christian. > > Am 13.07.2015 08:45 schrieb Archit Taneja : > > Remove FB_* config options since the driver doesn't call any fbdev > functions directly. > > Remove FB_KMS_HELPER as this would now be selected by the top level > FBDEV_EMULATION config option. If the fbdev emulation isn't selecte= d, > the drm_fb_helper functions will be stubbed out. > > Cc: Alex Deucher > Cc: Oded Gabbay > Cc: "Christian K=C3=B6nig" > > Signed-off-by: Archit Taneja > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig > b/drivers/gpu/drm/amd/amdgpu/Kconfig > index da7dcbf..2396482 100644 > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig > @@ -1,12 +1,8 @@ > config DRM_AMDGPU > tristate "AMD GPU" > depends on DRM && PCI > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > select FW_LOADER > select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > select DRM_TTM > select POWER_SUPPLY > select HWMON > --=20 > The Qualcomm Innovation Center, Inc. is a member of the Code > Aurora Forum, > hosted by The Linux Foundation > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------020507020007030700070603 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Please completely ignore that mail, my fatty fingers have selected the wrong mail for replying.

Regards,
Christian.

On 13.07.2015 09:08, Koenig, Christian wrote:

Hi Jammy,

I suggested to make the feature optional because of the unit test's.

There we don't need this feature and actually want t= o test the kernel functionality.

Regards,
Christian.

Am 13.07.2015 08:45 schrieb Archit Tanej= a <architt@codeaurora.org>:

Remove FB_* config options since the driver doesn't call any fbdev
functions directly.

Remove FB_KMS_HELPER as this would now be selected by the top level
FBDEV_EMULATION config option. If the fbdev emulation isn't selected,
the drm_fb_helper functions will be stubbed out.

Cc: Alex Deucher <alexander.deucher@amd.com><= br> Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com&= gt;

Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
=C2=A0drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ----
=C2=A01 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
index da7dcbf..2396482 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -1,12 +1,8 @@
=C2=A0config DRM_AMDGPU
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 tristate "= AMD GPU"
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on= DRM && PCI
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_FILLREC= T
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_COPYARE= A
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FB_CFB_IMAGEBL= IT
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select FW_= LOADER
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select DRM= _KMS_HELPER
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select DRM_KMS_FB_HEL= PER
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select DRM= _TTM
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select POW= ER_SUPPLY
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select HWM= ON
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/= dri-devel

--------------020507020007030700070603-- --===============0542438055== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0542438055==--