From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers Date: Tue, 14 Jul 2015 13:53:07 +0530 Message-ID: <55A4C6EB.7030108@codeaurora.org> References: <1436769848-4990-1-git-send-email-architt@codeaurora.org> <20150713153726.GY3736@phenom.ffwll.local> <55A4ACD7.6020001@codeaurora.org> <20150714080202.GA12465@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40824 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbbGNIXN (ORCPT ); Tue, 14 Jul 2015 04:23:13 -0400 In-Reply-To: <20150714080202.GA12465@ulmo.nvidia.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Thierry Reding Cc: Daniel Vetter , Alex Deucher , linux-arm-msm@vger.kernel.org, Maling list - DRI developers On 07/14/2015 01:32 PM, Thierry Reding wrote: > On Tue, Jul 14, 2015 at 12:01:51PM +0530, Archit Taneja wrote: >> Hi, >> >> On 07/13/2015 09:07 PM, Daniel Vetter wrote: >>> On Mon, Jul 13, 2015 at 11:30:34AM -0400, Alex Deucher wrote: >>>> On Mon, Jul 13, 2015 at 2:43 AM, Archit Taneja wrote: >>>>> With the top level DRM_FBDEV_EMULATION option, drivers don't need to >>>>> select DRM_FB_KMS_HELPER or other FB related config options in the >>>>> driver. >>>>> >>>>> Even if FBDEV_EMULATION isn't select, the stubbed out versions of >>>>> the drm_fb_helper functions will be called. >>>>> >>>>> There are some drivers which still need some FB stuff even after >>>>> these changes. They are qxl, udl and nouveau. These are handled a bit >>>>> differently compared to the other patches. >>>> >>>> Series is: >>>> Acked-by: Alex Deucher >>> >>> Archit for merging I think I'll just keep the current set of patches I >>> have for testing (well until there's a real bug discovered). Can you >>> please collect all the acks/r-bs/t-d when resending so I don't have to >>> digg them out when we merge the final versions of these? >>> >> >> Sure. I'll keep a track of this. >> >> Speaking of bugs, there was one thing I noticed in the series which I >> am not sure about. >> >> One of the new helpers wraps around framebuffer_alloc(). Most drivers >> tend to pass the drm_device's dev pointer to this, and this is what I >> do in the helper too. >> >> But some drivers(nouveau, radeon, qxl and some more) pass their >> pci_dev's dev pointer. > > As far as I can tell, for all PCI drivers the drm_device's dev pointer > is set to the pci_dev's dev pointer (via drm_get_pci_dev()), so this > shouldn't be changing anything at all. Thanks for pointing this out. This is a non-issue, then. Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project