From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 3/5] drm/i2c: adv7511: Refactor encoder slave functions Date: Tue, 28 Jul 2015 13:47:37 +0530 Message-ID: <55B73AA1.3040008@codeaurora.org> References: <1437977819-24199-1-git-send-email-architt@codeaurora.org> <1437977819-24199-4-git-send-email-architt@codeaurora.org> <2033050.HoN4SD9MIx@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2033050.HoN4SD9MIx@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, andy.green@linaro.org, srinivas.kandagatla@linaro.org List-Id: linux-arm-msm@vger.kernel.org SGksCgpPbiAwNy8yNy8yMDE1IDAyOjI5IFBNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+IEhp IEFyY2hpdCwKPgo+IChDQydpbmcgQm9yaXMgQnJlemlsbG9uKQo+Cj4gVGhhbmsgeW91IGZvciB0 aGUgcGF0Y2guCj4KPiBPbiBNb25kYXkgMjcgSnVseSAyMDE1IDExOjQ2OjU3IEFyY2hpdCBUYW5l amEgd3JvdGU6Cj4+IEFEVjc1MTEgaXMgcmVwcmVzZW50ZWQgYXMgYW4gaTJjIGRybSBzbGF2ZSBl bmNvZGVyIGRldmljZS4gQURWNzUzMywgb24KPj4gdGhlIG90aGVyIGhhbmQsIGlzIGdvaW5nIGJl IGEgbm9ybWFsIGkyYyBjbGllbnQgZGV2aWNlIGNyZWF0aW5nIGJyaWRnZQo+PiBhbmQgY29ubmVj dG9yIGVudGl0aWVzLgo+Cj4gUGxlYXNlLCBuby4gSXQncyByZWFsbHkgdGltZSB0byBzdG9wIHBp bGluZyBoYWNrcyBhbmQgZml4IHRoZSBwcm9ibGVtCj4gcHJvcGVybHkuIFRoZXJlJ3Mgbm8gcmVh c29uIHRvIGhhdmUgc2VwYXJhdGUgQVBJcyBmb3IgSTJDIHNsYXZlIGVuY29kZXJzIGFuZAo+IERS TSBicmlkZ2VzLiBUaG9zZSB0d28gQVBJcyBuZWVkIHRvIGJlIG1lcmdlZCwgYW5kIHRoZW4geW91 J2xsIGZpbmQgaXQgbXVjaAo+IGVhc2llciB0byBpbXBsZW1lbnQgQURWNzUzMyBzdXBwb3J0LgoK aTJjIHNsYXZlIGVuY29kZXJzIGFuZCBicmlkZ2VzIGFyZW4ndCBleGFjdGx5IHRoZSBzYW1lLiBz bGF2ZSBlbmNvZGVycwphcmUgdXNlZCB3aGVuIHRoZSB0aGVyZSBpcyBubyByZWFsICdlbmNvZGVy JyBpbiB0aGUgZGlzcGxheSBjaGFpbi4KYnJpZGdlcyBhcmUgdXNlZCB3aGVuIHRoZXJlIGlzIGFs cmVhZHkgYW4gZW5jb2RlciBhdmFpbGFibGUsIGFuZCB0aGUKYnJpZGdlIGVudGl0eSByZXByZXNl bnRzIGFub3RoZXIgZW5jb2RlciBpbiB0aGUgY2hhaW4uCgpBRFY3NTExIHRha2VzIGluIFJHQi9N SVBJIERQSSBkYXRhLCB3aGljaCBpcyBnZW5lcmFsbHkgdGhlIG91dHB1dCBvZiBhIApjcnRjIGZv ciBkcm0gZHJpdmVycy4KCkFEVjc1MzMgdGFrZXMgaW4gTUlQSSBEU0kgZGF0YSwgd2hpY2ggaXMg Z2VuZXJhbGx5IHRoZSBvdXRwdXQgb2YgYW4KZW5jb2RlciBmb3IgZHJtIGRyaXZlcnMuCgpUaGVy ZWZvcmUsIGhhdmluZyBpMmMgc2xhdmUgZW5jb2RlciBmb3IgdGhlIGZvcm1lciBhbmQgYnJpZGdl IGZvciB0aGUKbGF0dGVyIG1hZGUgc2Vuc2UgdG8gbWUuCgpJIGRvIGFncmVlIHRoYXQgaXQgd291 bGQgYmUgYmV0dGVyIGlmIHRoZXkgd2VyZSBzb21laG93IG1lcmdlZC4gSXQKd291bGQgcHJldmVu dCB0aGUgZnJhZ21lbnRhdGlvbiB3ZSBjdXJyZW50bHkgaGF2ZSBhbW9uZyBlbmNvZGVyCmNoaXBz LgoKT25lIHBvc3NpYmxlIHdheSB3b3VsZCBiZSB0byBjb252ZXJ0IHNsYXZlIGVuY29kZXIgdG8g YnJpZGdlLiBXaXRoCnRoaXMsIGFuIGkyYyBzbGF2ZSBlbmNvZGVyIHdvdWxkIGJlIGEgJ2R1bW15 IGVuY29kZXInIGFuZCBhIGJyaWRnZS4KaTJjIHNsYXZlIGVuY29kZXJzIGV2ZW4gbm93IGp1c3Qg dGllIHRoZSBzbGF2ZSBlbmNvZGVyIGhlbHBlciBmdW5jcwp0byBlbmNvZGVyIGhlbHBlciBmdW5j cy4gU28gaXQncyBub3QgcmVhbGx5IGFueSBkaWZmZXJlbnQuCgpNZXJnaW5nIHRoZXNlIDIgZW50 aXRpZXMgd291bGQgYmUgbmljZSwgYnV0IHdlJ3JlIHN0aWxsIHNoeWluZyBhd2F5CmZyb20gdGhl IGxhcmdlciBwcm9ibGVtIG9mIGNyZWF0aW5nIGdlbmVyaWMgZW5jb2RlciBjaGFpbnMuIFRoZQpp ZGVhbCBzb2x1dGlvbiB3b3VsZCBiZSBmb3IgYnJpZGdlcyBhbmQgc2xhdmUgZW5jb2RlcnMgdG8g anVzdCBiZQonZW5jb2RlcnMnLCBhbmQgdGhlIGZhY2lsaXR5IHRvIGNvbm5lY3Qgb24gZW5jb2Rl ciBvdXRwdXQgdG8gdGhlCmlucHV0IG9mIGFub3RoZXIuIEkgZG9uJ3Qga25vdyBob3cgZWFzeSBp dCBpcyB0byBkbyB0aGlzLCBhbmQKd2hldGhlciBpdCdsbCBicmVhayB1c2Vyc3BhY2UuCgpBcmNo aXQKCj4KPiBCb3JpcywgSSBrbm93IHlvdSB3ZXJlIGV4cGVyaW1lbnRpbmcgd2l0aCB0aGF0LCBk byB5b3UgaGF2ZSBhbnl0aGluZyB0byByZXBvcnQKPiA/Cj4KPj4gTW92ZSB0aGUgY29kZSBpbiBl bmNvZGVyIHNsYXZlIGZ1bmN0aW9ucyB0byBnZW5lcmF0ZSBoZWxwZXJzIHRoYXQgYXJlCj4+IGFn bm9zdGljIHRvIHRoZSBkcm0gb2JqZWN0IHR5cGUuIFRoZXNlIGhlbHBlcnMgd2lsbCBsYXRlciBh bHNvIGJlIHVzZWQKPj4gYnkgYnJpZGdlIGFuZCBjb25uZWN0ZXIgaGVscGVyIGZ1bmN0aW9ucy4K Pj4KPj4gU2lnbmVkLW9mZi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9y Zz4KPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMgfCA4MCArKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgNTcg aW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTJjL2Fkdjc1MTEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jCj4+ IGluZGV4IDYzYTNkMjAuLjQ2ZmIyNGQgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p MmMvYWR2NzUxMS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jCj4+IEBA IC02MTIsMTMgKzYxMiwxMSBAQCBzdGF0aWMgaW50IGFkdjc1MTFfZ2V0X2VkaWRfYmxvY2sodm9p ZCAqZGF0YSwgdTggKmJ1ZiwKPj4gdW5zaWduZWQgaW50IGJsb2NrLCB9Cj4+Cj4+ICAgLyoKPj4g LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4+IC0tIC0gKiBFbmNvZGVyIG9wZXJhdGlvbnMKPj4gKyAqIEFE Vjc1eHggaGVscGVycwo+PiAgICAqLwo+PiAtCj4+IC1zdGF0aWMgaW50IGFkdjc1MTFfZ2V0X21v ZGVzKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPj4gLQkJCSAgICAgc3RydWN0IGRybV9j b25uZWN0b3IgKmNvbm5lY3RvcikKPj4gK3N0YXRpYyBpbnQgYWR2NzUxMV9nZXRfbW9kZXMoc3Ry dWN0IGFkdjc1MTEgKmFkdjc1MTEsCj4+ICsJCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IpCj4+ICAgewo+PiAtCXN0cnVjdCBhZHY3NTExICphZHY3NTExID0gZW5jb2Rlcl90b19hZHY3 NTExKGVuY29kZXIpOwo+PiAgIAlzdHJ1Y3QgZWRpZCAqZWRpZDsKPj4gICAJdW5zaWduZWQgaW50 IGNvdW50Owo+Pgo+PiBAQCAtNjU2LDIxICs2NTQsMTAgQEAgc3RhdGljIGludCBhZHY3NTExX2dl dF9tb2RlcyhzdHJ1Y3QgZHJtX2VuY29kZXIKPj4gKmVuY29kZXIsIHJldHVybiBjb3VudDsKPj4g ICB9Cj4+Cj4+IC1zdGF0aWMgdm9pZCBhZHY3NTExX2VuY29kZXJfZHBtcyhzdHJ1Y3QgZHJtX2Vu Y29kZXIgKmVuY29kZXIsIGludCBtb2RlKQo+PiAtewo+PiAtCXN0cnVjdCBhZHY3NTExICphZHY3 NTExID0gZW5jb2Rlcl90b19hZHY3NTExKGVuY29kZXIpOwo+PiAtCj4+IC0JaWYgKG1vZGUgPT0g RFJNX01PREVfRFBNU19PTikKPj4gLQkJYWR2NzUxMV9wb3dlcl9vbihhZHY3NTExKTsKPj4gLQll bHNlCj4+IC0JCWFkdjc1MTFfcG93ZXJfb2ZmKGFkdjc1MTEpOwo+PiAtfQo+PiAtCj4+ICAgc3Rh dGljIGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMKPj4gLWFkdjc1MTFfZW5jb2Rlcl9kZXRlY3Qo c3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+PiArYWR2NzUxMV9kZXRlY3Qoc3RydWN0IGFk djc1MTEgKmFkdjc1MTEsCj4+ICAgCQkgICAgICAgc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvcikKPj4gICB7Cj4+IC0Jc3RydWN0IGFkdjc1MTEgKmFkdjc1MTEgPSBlbmNvZGVyX3RvX2Fk djc1MTEoZW5jb2Rlcik7Cj4+ICAgCWVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMgc3RhdHVzOwo+ PiAgIAl1bnNpZ25lZCBpbnQgdmFsOwo+PiAgIAlib29sIGhwZDsKPj4gQEAgLTY5NCw3ICs2ODEs NyBAQCBhZHY3NTExX2VuY29kZXJfZGV0ZWN0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwK Pj4gICAJaWYgKHN0YXR1cyA9PSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCAmJiBocGQgJiYg YWR2NzUxMS0+cG93ZXJlZCkgewo+PiAgIAkJcmVnY2FjaGVfbWFya19kaXJ0eShhZHY3NTExLT5y ZWdtYXApOwo+PiAgIAkJYWR2NzUxMV9wb3dlcl9vbihhZHY3NTExKTsKPj4gLQkJYWR2NzUxMV9n ZXRfbW9kZXMoZW5jb2RlciwgY29ubmVjdG9yKTsKPj4gKwkJYWR2NzUxMV9nZXRfbW9kZXMoYWR2 NzUxMSwgY29ubmVjdG9yKTsKPj4gICAJCWlmIChhZHY3NTExLT5zdGF0dXMgPT0gY29ubmVjdG9y X3N0YXR1c19jb25uZWN0ZWQpCj4+ICAgCQkJc3RhdHVzID0gY29ubmVjdG9yX3N0YXR1c19kaXNj b25uZWN0ZWQ7Cj4+ICAgCX0gZWxzZSB7Cj4+IEBAIC03MDgsOCArNjk1LDggQEAgYWR2NzUxMV9l bmNvZGVyX2RldGVjdChzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCj4+ICAgCXJldHVybiBz dGF0dXM7Cj4+ICAgfQo+Pgo+PiAtc3RhdGljIGludCBhZHY3NTExX2VuY29kZXJfbW9kZV92YWxp ZChzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCj4+IC0JCQkJICAgICAgc3RydWN0IGRybV9k aXNwbGF5X21vZGUgKm1vZGUpCj4+ICtzdGF0aWMgaW50IGFkdjc1MTFfbW9kZV92YWxpZChzdHJ1 Y3QgYWR2NzUxMSAqYWR2NzUxMSwKPj4gKwkJCQkgICAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICptb2RlKQo+PiAgIHsKPj4gICAJaWYgKG1vZGUtPmNsb2NrID4gMTY1MDAwKQo+PiAg IAkJcmV0dXJuIE1PREVfQ0xPQ0tfSElHSDsKPj4gQEAgLTcxNywxMSArNzA0LDEwIEBAIHN0YXRp YyBpbnQgYWR2NzUxMV9lbmNvZGVyX21vZGVfdmFsaWQoc3RydWN0Cj4+IGRybV9lbmNvZGVyICpl bmNvZGVyLCByZXR1cm4gTU9ERV9PSzsKPj4gICB9Cj4+Cj4+IC1zdGF0aWMgdm9pZCBhZHY3NTEx X2VuY29kZXJfbW9kZV9zZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+PiArc3RhdGlj IHZvaWQgYWR2NzUxMV9tb2RlX3NldChzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSwKPj4gICAJCQkJ ICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPj4gICAJCQkJICAgICBzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqYWRqX21vZGUpCj4+ICAgewo+PiAtCXN0cnVjdCBhZHY3NTExICph ZHY3NTExID0gZW5jb2Rlcl90b19hZHY3NTExKGVuY29kZXIpOwo+PiAgIAl1bnNpZ25lZCBpbnQg bG93X3JlZnJlc2hfcmF0ZTsKPj4gICAJdW5zaWduZWQgaW50IGhzeW5jX3BvbGFyaXR5ID0gMDsK Pj4gICAJdW5zaWduZWQgaW50IHZzeW5jX3BvbGFyaXR5ID0gMDsKPj4gQEAgLTgxMiwxMiArNzk4 LDYwIEBAIHN0YXRpYyB2b2lkIGFkdjc1MTFfZW5jb2Rlcl9tb2RlX3NldChzdHJ1Y3QKPj4gZHJt X2VuY29kZXIgKmVuY29kZXIsIGFkdjc1MTEtPmZfdG1kcyA9IG1vZGUtPmNsb2NrOwo+PiAgIH0K Pj4KPj4gKy8qCj4+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAtLSArICogRW5jb2RlciBvcGVyYXRp b25zCj4+ICsgKi8KPj4gKwo+PiArc3RhdGljIGludCBhZHY3NTExX2VuY29kZXJfZ2V0X21vZGVz KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPj4gKwkJCSAgICAgc3RydWN0IGRybV9jb25u ZWN0b3IgKmNvbm5lY3RvcikKPj4gK3sKPj4gKwlzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSA9IGVu Y29kZXJfdG9fYWR2NzUxMShlbmNvZGVyKTsKPj4gKwo+PiArCXJldHVybiBhZHY3NTExX2dldF9t b2RlcyhhZHY3NTExLCBjb25uZWN0b3IpOwo+PiArfQo+PiArCj4+ICtzdGF0aWMgdm9pZCBhZHY3 NTExX2VuY29kZXJfZHBtcyhzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsIGludCBtb2RlKQo+ PiArewo+PiArCXN0cnVjdCBhZHY3NTExICphZHY3NTExID0gZW5jb2Rlcl90b19hZHY3NTExKGVu Y29kZXIpOwo+PiArCj4+ICsJaWYgKG1vZGUgPT0gRFJNX01PREVfRFBNU19PTikKPj4gKwkJYWR2 NzUxMV9wb3dlcl9vbihhZHY3NTExKTsKPj4gKwllbHNlCj4+ICsJCWFkdjc1MTFfcG93ZXJfb2Zm KGFkdjc1MTEpOwo+PiArfQo+PiArCj4+ICtzdGF0aWMgZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1 cwo+PiArYWR2NzUxMV9lbmNvZGVyX2RldGVjdChzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIs Cj4+ICsJCSAgICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+PiArewo+PiAr CXN0cnVjdCBhZHY3NTExICphZHY3NTExID0gZW5jb2Rlcl90b19hZHY3NTExKGVuY29kZXIpOwo+ PiArCj4+ICsJcmV0dXJuIGFkdjc1MTFfZGV0ZWN0KGFkdjc1MTEsIGNvbm5lY3Rvcik7Cj4+ICt9 Cj4+ICsKPj4gK3N0YXRpYyBpbnQgYWR2NzUxMV9lbmNvZGVyX21vZGVfdmFsaWQoc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyLAo+PiArCQkJCSAgICAgIHN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl ICptb2RlKQo+PiArewo+PiArCXN0cnVjdCBhZHY3NTExICphZHY3NTExID0gZW5jb2Rlcl90b19h ZHY3NTExKGVuY29kZXIpOwo+PiArCj4+ICsJcmV0dXJuIGFkdjc1MTFfbW9kZV92YWxpZChhZHY3 NTExLCBtb2RlKTsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZvaWQgYWR2NzUxMV9lbmNvZGVyX21v ZGVfc2V0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPj4gKwkJCQkgICAgIHN0cnVjdCBk cm1fZGlzcGxheV9tb2RlICptb2RlLAo+PiArCQkJCSAgICAgc3RydWN0IGRybV9kaXNwbGF5X21v ZGUgKmFkal9tb2RlKQo+PiArewo+PiArCXN0cnVjdCBhZHY3NTExICphZHY3NTExID0gZW5jb2Rl cl90b19hZHY3NTExKGVuY29kZXIpOwo+PiArCj4+ICsJYWR2NzUxMV9tb2RlX3NldChhZHY3NTEx LCBtb2RlLCBhZGpfbW9kZSk7Cj4+ICt9Cj4+ICsKPj4gICBzdGF0aWMgc3RydWN0IGRybV9lbmNv ZGVyX3NsYXZlX2Z1bmNzIGFkdjc1MTFfZW5jb2Rlcl9mdW5jcyA9IHsKPj4gICAJLmRwbXMgPSBh ZHY3NTExX2VuY29kZXJfZHBtcywKPj4gICAJLm1vZGVfdmFsaWQgPSBhZHY3NTExX2VuY29kZXJf bW9kZV92YWxpZCwKPj4gICAJLm1vZGVfc2V0ID0gYWR2NzUxMV9lbmNvZGVyX21vZGVfc2V0LAo+ PiAgIAkuZGV0ZWN0ID0gYWR2NzUxMV9lbmNvZGVyX2RldGVjdCwKPj4gLQkuZ2V0X21vZGVzID0g YWR2NzUxMV9nZXRfbW9kZXMsCj4+ICsJLmdldF9tb2RlcyA9IGFkdjc1MTFfZW5jb2Rlcl9nZXRf bW9kZXMsCj4+ICAgfTsKPj4KPj4gICAvKgo+PiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gLS0KPgoK LS0gClF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUg QXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==