linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names
Date: Mon, 10 Aug 2015 14:18:15 +0100	[thread overview]
Message-ID: <55C8A497.9050600@linaro.org> (raw)
In-Reply-To: <20150810124947.GD1262@ulmo.nvidia.com>



On 10/08/15 13:49, Thierry Reding wrote:
> On Mon, Aug 10, 2015 at 12:59:49PM +0100, Srinivas Kandagatla wrote:
>> This patch updates the bindings to discourage the usage of non standard
>> clock names, this will help in projects focused on upstreaming.
>>
>> These deprecated properties are still supported but will be remove over
>> the time.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/drm/msm/hdmi.txt | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/drm/msm/hdmi.txt b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
>> index 6dc202e..6fbfdd8 100644
>> --- a/Documentation/devicetree/bindings/drm/msm/hdmi.txt
>> +++ b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
>> @@ -12,16 +12,16 @@ Required properties:
>>   - clocks: device clocks
>>   - clock-names: Corresponding name for each entry in the clocks property.
>>    for "qcom,hdmi-tx-8960" compatible names should be
>> -	"core_clk"
>> -	"master_iface_clk"
>> -	"slave_iface_clk"
>> +	"core_clk" is deprecated, use "core" instead
>> +	"master_iface_clk" is deprecated, use "master_iface" instead
>> +	"slave_iface_clk" is deprecated, use "slave_iface" instead
>>
>>    for "qcom,hdmi-tx-8084" and "qcom,hdmi-tx-8074" compatible names should be
>> -	"extp_clk"
>> -	"alt_iface_clk"
>> -	"iface_clk"
>> -	"core_clk"
>> -	"mdp_core_clk"
>> +	"extp_clk" is deprecated, use "extp" instead
>> +	"alt_iface_clk" is deprecated, use "alt_iface" intstead
>> +	"iface_clk" is deprecated, use "iface" instead
>> +	"core_clk" is deprecated, use "core" instead
>> +	"mdp_core_clk" is deprecated, use "mdp_core" instead
>
> Shouldn't there be a driver counterpart of this to accept the new names?
Driver changes are in this same series "[PATCH RFC 5/5] drm/msm/hdmi: 
remove _clk suffix from clock names"(https://lkml.org/lkml/2015/8/10/453)

--srini
> Otherwise people could be switching the DTS to the new value, but the
> driver won't find the clocks it's looking for.
>
> Thierry
>

  reply	other threads:[~2015-08-10 13:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:58 [PATCH RFC 0/5] drm/msm/hdmi: DT bindings cleanup Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties Srinivas Kandagatla
2015-08-10 12:45   ` Thierry Reding
2015-08-10 22:07     ` Rob Herring
2015-08-10 22:27       ` Bjorn Andersson
2015-08-11  0:25         ` Rob Clark
2015-08-10 11:59 ` [PATCH RFC 2/5] drm/msm/hdmi: make use of " Srinivas Kandagatla
2015-08-10 12:38   ` Thierry Reding
2015-08-10 13:15     ` Srinivas Kandagatla
2015-08-10 13:26       ` Thierry Reding
2015-08-10 13:49         ` Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 3/5] drm/msm/hdmi: update bindings to include clock-names Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla
2015-08-10 12:49   ` Thierry Reding
2015-08-10 13:18     ` Srinivas Kandagatla [this message]
2015-08-10 13:33       ` Thierry Reding
2015-08-10 13:42         ` Srinivas Kandagatla
2015-08-10 11:59 ` [PATCH RFC 5/5] drm/msm/hdmi: remove _clk suffix from clock names Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C8A497.9050600@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).