From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH 6/6] drm/msm: add OCMEM driver Date: Wed, 30 Sep 2015 10:51:05 +0300 Message-ID: <560B9469.7030103@linaro.org> References: <1443556138-21085-1-git-send-email-robdclark@gmail.com> <1443556138-21085-7-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f169.google.com ([209.85.212.169]:38646 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754352AbbI3HvL (ORCPT ); Wed, 30 Sep 2015 03:51:11 -0400 Received: by wiclk2 with SMTP id lk2so48665049wic.1 for ; Wed, 30 Sep 2015 00:51:10 -0700 (PDT) In-Reply-To: <1443556138-21085-7-git-send-email-robdclark@gmail.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Clark , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: Bjorn Andersson , Stephen Boyd Hi Rob, Thanks for your work. On 09/29/2015 10:48 PM, Rob Clark wrote: > For now, since the GPU is the only upstream consumer, just stuff this > into drm/msm. Eventually if we have other consumers, we'll have to As the video encoder/decoder driver (vidc) for apq8084 && msm8974 also use the ocmem for scratch buffers, it might be better to relocate the ocmem driver in drivers/soc/qcom from the beginning? I'm working on vidc driver upstream version so it will be nice to test ocmem driver from it, too. > split this out and make the allocation less hard coded. But I'll punt > on that until I better understand the non-gpu uses-cases (and whether > the allocation *really* needs to be as complicated as it is in the > downstream driver). > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile | 3 +- > drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 19 +- > drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 19 +- > drivers/gpu/drm/msm/msm_drv.c | 2 + > drivers/gpu/drm/msm/msm_gpu.h | 3 + > drivers/gpu/drm/msm/ocmem/ocmem.c | 399 ++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/msm/ocmem/ocmem.h | 46 ++++ > 7 files changed, 463 insertions(+), 28 deletions(-) > create mode 100644 drivers/gpu/drm/msm/ocmem/ocmem.c > create mode 100644 drivers/gpu/drm/msm/ocmem/ocmem.h > -- regards, Stan