From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Huntsman Subject: Re: [PATCH] soc/qcom: add OCMEM driver Date: Fri, 23 Oct 2015 10:52:33 -0700 Message-ID: <562A73E1.5010701@codeaurora.org> References: <1444686342-19344-1-git-send-email-robdclark@gmail.com> <562A2405.7070103@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:37949 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbJWRwi (ORCPT ); Fri, 23 Oct 2015 13:52:38 -0400 In-Reply-To: <562A2405.7070103@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stanimir Varbanov , Rob Clark , linux-arm-msm@vger.kernel.org Cc: Stephen Boyd , Bjorn Andersson On 10/23/2015 05:11 AM, Stanimir Varbanov wrote: > Hi Rob, ... >> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig >> index 266060b..b485043 100644 >> --- a/drivers/soc/qcom/Kconfig >> +++ b/drivers/soc/qcom/Kconfig >> @@ -74,3 +74,9 @@ config QCOM_WCNSS_CTRL >> help >> Client driver for the WCNSS_CTRL SMD channel, used to download nv >> firmware to a newly booted WCNSS chip. >> + >> +config QCOM_OCMEM >> + tristate "Qualcomm OCMEM driver" >> + depends on QCOM_SMD > > Why this driver depends on SMD, I cannot see where smd is used here. > > Maybe depends on ARCH_QCOM should be sufficient? AFAIK, Stan is correct. OCMEM should only be used by GPU w/o any of the SMD stuff, so ARCH_QCOM looks better. - Bryan -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project