From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] clk: qcom: msm8960: Fix dsi1/2 halt bits Date: Tue, 27 Oct 2015 11:02:14 +0530 Message-ID: <562F0C5E.7050307@codeaurora.org> References: <1445909002-31576-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50257 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbbJ0FcT (ORCPT ); Tue, 27 Oct 2015 01:32:19 -0400 In-Reply-To: <1445909002-31576-1-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , Mike Turquette Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org On 10/27/2015 06:53 AM, Stephen Boyd wrote: > The halt bits for these clocks seem wrong. I get the following > warning while booting on an msm8960-cdp: > > WARNING: CPU: 0 PID: 1 at drivers/clk/qcom/clk-branch.c:97 clk_branch_toggle+0xd0/0x138() > dsi1_clk status stuck at 'on' > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.3.0-rc3-00113-g5532cfb567fe #110 > Hardware name: Qualcomm (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0x70/0xbc) > [] (dump_stack) from [] (warn_slowpath_common+0x78/0xb4) > [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) > [] (warn_slowpath_fmt) from [] (clk_branch_toggle+0xd0/0x138) > [] (clk_branch_toggle) from [] (clk_disable_unused_subtree+0x98/0x1b0) > [] (clk_disable_unused_subtree) from [] (clk_disable_unused_subtree+0x20/0x1b0) > [] (clk_disable_unused_subtree) from [] (clk_disable_unused+0x58/0xd8) > [] (clk_disable_unused) from [] (do_one_initcall+0xac/0x1ec) > [] (do_one_initcall) from [] (kernel_init_freeable+0x11c/0x1e8) > [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) > [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) > > Fix the status bits and the errors go away. > > Fixes: 5532cfb567fe ("clk: qcom: mmcc-8960: Add DSI related clocks") > Cc: Archit Taneja > Signed-off-by: Stephen Boyd > --- Acked-by: Archit Taneja -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation