From: Hannes Reinecke <hare@suse.de>
To: Yaniv Gardi <ygardi@codeaurora.org>,
robherring2@gmail.com, James.Bottomley@HansenPartnership.com,
pebolle@tiscali.nl, hch@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
gbroner@codeaurora.org, draviv@codeaurora.org,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH v9 1/8] phy: qcom-ufs: fix build error when the component is built as a module
Date: Fri, 30 Oct 2015 09:25:00 +0100 [thread overview]
Message-ID: <5633295C.7030800@suse.de> (raw)
In-Reply-To: <1446030951-2431-2-git-send-email-ygardi@codeaurora.org>
On 10/28/2015 12:15 PM, Yaniv Gardi wrote:
> Export the following functions in order to avoid build errors
> when the component PHY_QCOM_UFS is compiled as a module:
>
> ERROR: "ufs_qcom_phy_disable_ref_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_enable_ref_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_is_pcs_ready"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_disable_iface_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_start_serdes"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_calibrate_phy"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_enable_dev_ref_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_set_tx_lane_enable"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_disable_dev_ref_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_save_controller_version"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> ERROR: "ufs_qcom_phy_enable_iface_clk"
> [drivers/scsi/ufs/ufs-qcom.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
> Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
> Reviewed-by: Gilad Broner <gbroner@codeaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---
> drivers/phy/phy-qcom-ufs.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2015-10-30 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 11:15 [PATCH v9 0/8] Fix error message and present UFS variant Yaniv Gardi
2015-10-28 11:15 ` [PATCH v9 1/8] phy: qcom-ufs: fix build error when the component is built as a module Yaniv Gardi
2015-10-30 8:25 ` Hannes Reinecke [this message]
2015-10-28 11:15 ` [PATCH v9 2/8] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-10-30 8:26 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-10-30 8:26 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 4/8] scsi: ufs: add ufshcd_get_variant ufshcd_set_variant Yaniv Gardi
2015-10-30 8:28 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 5/8] scsi: ufs: creates wrapper functions for vops Yaniv Gardi
2015-10-30 8:28 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 6/8] scsi: ufs: make the UFS variant a platform device Yaniv Gardi
2015-10-30 8:30 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 7/8] scsi: ufs-qcom: add debug prints for test bus Yaniv Gardi
2015-10-30 8:31 ` Hannes Reinecke
2015-10-28 11:15 ` [PATCH v9 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations Yaniv Gardi
2015-10-30 8:32 ` Hannes Reinecke
2015-11-03 0:59 ` [PATCH v9 0/8] Fix error message and present UFS variant Alim Akhtar
2015-11-10 0:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5633295C.7030800@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=robherring2@gmail.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).