From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V2 2/3] scsi: fix compiler warning for sg Date: Mon, 9 Nov 2015 22:21:15 -0500 Message-ID: <564162AB.6080803@codeaurora.org> References: <1447034266-28003-1-git-send-email-okaya@codeaurora.org> <1447034266-28003-3-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: Doug Gilbert , "James E.J. Bottomley" , linux-scsi , linux-arm-msm@vger.kernel.org, timur@codeaurora.org, Andy Gross , "linux-kernel@vger.kernel.org" , cov@codeaurora.org, jcm@redhat.com, linux-arm Mailing List List-Id: linux-arm-msm@vger.kernel.org On 11/9/2015 9:14 AM, Andy Shevchenko wrote: > Parens are useless, noticed later, sorry. > > Isn't mult_frac() enough here? > > Btw, can you mention explicitly what is the warning you get > (copy'n'paste of the line would be okay)? I created this patch back in March with an older version of the compiler and older kernel (3.19). I'm no longer able to reproduce this with this compiler and linux-next. Thread model: posix gcc version 4.8.3 20140401 (prerelease) (crosstool-NG linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04) I'll drop this patch. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project