From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver Date: Sun, 22 Nov 2015 21:31:35 -0500 Message-ID: <56527A87.80201@codeaurora.org> References: <1448210257-4768-1-git-send-email-okaya@codeaurora.org> <1448210257-4768-3-git-send-email-okaya@codeaurora.org> <565bdce834ba1cf4a73029b5c027856e.squirrel@www.codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44259 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131AbbKWCbm (ORCPT ); Sun, 22 Nov 2015 21:31:42 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Andy Shevchenko Cc: dmaengine , Timur Tabi , cov@codeaurora.org, jcm@redhat.com, Andy Gross , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-arm Mailing List , "linux-kernel@vger.kernel.org" >>> >>> Can it be like >>> >>> /sys/=E2=80=A6/DEVICExx/ >>> channelYY/ >>> attr1 >>> attr2 >>> =E2=80=A6 >>> >>> ? >> >> I'll work on it. I didn't know that you are allowed to create subdir= ectories >> in sysfs. I was just creating attributes to keep it simple. But, you= r >> suggestion is cleaner. >> >>> >>> I think it will be easier to handle in code and from user. (Similar >>> way DMAEngine API does for slave DMA devices) >> >> Now, the good stuff. Can you clarify your comment? I didn't understa= nd it. >=20 > I meant that DMAEngine uses > /sys/class/dma > dmaYchannelX/ > attr1 > attr2 > =E2=80=A6 >=20 > layout. >=20 I have posted v7 with this change. --=20 Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, In= c. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project