From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/3] clocksource: defbool CLKSRC_QCOM=y on ARCH_QCOM and make it visible Date: Wed, 25 Nov 2015 13:37:53 +0100 Message-ID: <5655ABA1.6030206@linaro.org> References: <1448413710-8101-1-git-send-email-sboyd@codeaurora.org> <1448413710-8101-2-git-send-email-sboyd@codeaurora.org> <56558929.6090403@linaro.org> <3550727.W9y7mWx54D@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <3550727.W9y7mWx54D@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross List-Id: linux-arm-msm@vger.kernel.org On 11/25/2015 11:17 AM, Arnd Bergmann wrote: > On Wednesday 25 November 2015 11:10:49 Daniel Lezcano wrote: >> On 11/25/2015 02:08 AM, Stephen Boyd wrote: >>> We want to remove the ARCH_MSM* configs in mach-qcom/Kconfig >>> because they are mostly proxy configs for selecting the right >>> clocksource driver. Therefore, make CLKSRC_QCOM default to the >>> value of ARCH_QCOM, but also make it visible if ARCH_QCOM=3Dy so >>> that we can turn it off when we don't want it. >> >> I have been removing the ARCH dependencies in the Kconfig file. >> >> Why do you have to turn it off manually ? > > The background is that this is used only on some of the older > MSM SoCs, while the newer ones use the arch timer. > > We decided to remove the SoC-specific top-level options from > mach-msm as they are becoming rather meaningless these days > and just a burden to maintain at the rate that new variants > get released, so being able to turn off this driver helps make > the kernel slightly smaller if you are building a kernel for > only the more recent models. Ok, thanks for the clarification. I don't really like this approach even if it is correct because it=20 breaks the current approach I am trying to make consistent across the=20 drivers. I would like to have the COMPILE_TEST option available for all the=20 drivers and move this option under the menu config. This patch will=20 prevent to do this code factoring. On the other side, this option is supposed to have a slightly smaller=20 kernel when it is not used. But when does it happen ? When=20 ARCH_MSM8X60=3Dn and ARCH_MSM8960=3Dn. With this patchset, I don't see = the=20 ability to turn these SoCs off as the options are removed. So the=20 associated code is not removed, right ? So why allow to turn off the timer but disallow that for the entire SoC= ? --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog