From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] mfd: qcom-spmi-pmic: Don't access non-existing registers Date: Wed, 6 Jan 2016 17:50:14 -0800 Message-ID: <568DC456.9060300@codeaurora.org> References: <1447805204-32483-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:34472 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbcAGBuQ (ORCPT ); Wed, 6 Jan 2016 20:50:16 -0500 In-Reply-To: <1447805204-32483-1-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lee Jones Cc: "Ivan T. Ivanov" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 11/17/15 16:06, Stephen Boyd wrote: > From: "Ivan T. Ivanov" > > Revision ID registers are available only on devices with > Slave IDs that are even, so don't make access to unavailable > registers. > > Signed-off-by: Ivan T. Ivanov > [sboyd@codeaurora.org: Consider all slave ids that are even] > Signed-off-by: Stephen Boyd > --- Ping? > drivers/mfd/qcom-spmi-pmic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index af6ac1c4b45c..8653e8b9bb4f 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -127,7 +127,9 @@ static int pmic_spmi_probe(struct spmi_device *sdev) > if (IS_ERR(regmap)) > return PTR_ERR(regmap); > > - pmic_spmi_show_revid(regmap, &sdev->dev); > + /* Only the first slave id for a PMIC contains this information */ > + if (sdev->usid % 2 == 0) > + pmic_spmi_show_revid(regmap, &sdev->dev); > > return of_platform_populate(root, NULL, NULL, &sdev->dev); > } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project