From: Georgi Djakov <georgi.djakov@linaro.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: andy.gross@linaro.org, sboyd@codeaurora.org, broonie@kernel.org,
linux-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: Add support for SAW2 regulators
Date: Thu, 7 Jan 2016 15:50:30 +0200 [thread overview]
Message-ID: <568E6D26.3010409@linaro.org> (raw)
In-Reply-To: <20151218172453.GF3342@linaro.org>
On 12/18/2015 07:24 PM, Lina Iyer wrote:
> On Fri, Dec 18 2015 at 09:15 -0700, Georgi Djakov wrote:
>> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper)
>> is part of the SPM subsystem. It is a hardware block found on some of the
>> Qualcomm chipsets, which regulates the power to the CPU cores. Add some
>> basic support for it, so that we can do dynamic voltage scaling.
>>
>> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
>> ---
[..]
>> @@ -368,6 +510,11 @@ static int spm_dev_probe(struct platform_device *pdev)
>>
>> per_cpu(cpu_spm_drv, cpu) = drv;
>>
>> + ret = register_saw2_regulator(drv, pdev, cpu);
>>
> Not all SAWs are regulators. On 8084, only the L2 SAW is a regulator.
> You may want to parse the device node to see if it has a 'regulator'
> property and then initialize the regulator aspect of the SAW. L2 SAW
> nodes are not present in the upstream kernel. You can find a patch that
> adds cache SPM here in my WIP series at [1].
Yes, nice catch. Thank you!
BR,
Georgi
prev parent reply other threads:[~2016-01-07 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 16:14 [PATCH] soc: qcom: Add support for SAW2 regulators Georgi Djakov
2015-12-18 17:22 ` Mark Brown
2016-01-07 13:47 ` Georgi Djakov
2016-01-12 2:34 ` Stephen Boyd
2015-12-18 17:24 ` Lina Iyer
2016-01-07 13:50 ` Georgi Djakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E6D26.3010409@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).