From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH] soc: qcom: Add support for SAW2 regulators Date: Thu, 7 Jan 2016 15:50:30 +0200 Message-ID: <568E6D26.3010409@linaro.org> References: <1450455298-1987-1-git-send-email-georgi.djakov@linaro.org> <20151218172453.GF3342@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:34166 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbcAGNud (ORCPT ); Thu, 7 Jan 2016 08:50:33 -0500 Received: by mail-wm0-f51.google.com with SMTP id u188so99123634wmu.1 for ; Thu, 07 Jan 2016 05:50:33 -0800 (PST) In-Reply-To: <20151218172453.GF3342@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer Cc: andy.gross@linaro.org, sboyd@codeaurora.org, broonie@kernel.org, linux-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org On 12/18/2015 07:24 PM, Lina Iyer wrote: > On Fri, Dec 18 2015 at 09:15 -0700, Georgi Djakov wrote: >> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper) >> is part of the SPM subsystem. It is a hardware block found on some of the >> Qualcomm chipsets, which regulates the power to the CPU cores. Add some >> basic support for it, so that we can do dynamic voltage scaling. >> >> Signed-off-by: Georgi Djakov >> --- [..] >> @@ -368,6 +510,11 @@ static int spm_dev_probe(struct platform_device *pdev) >> >> per_cpu(cpu_spm_drv, cpu) = drv; >> >> + ret = register_saw2_regulator(drv, pdev, cpu); >> > Not all SAWs are regulators. On 8084, only the L2 SAW is a regulator. > You may want to parse the device node to see if it has a 'regulator' > property and then initialize the regulator aspect of the SAW. L2 SAW > nodes are not present in the upstream kernel. You can find a patch that > adds cache SPM here in my WIP series at [1]. Yes, nice catch. Thank you! BR, Georgi