From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: Add pinctrl driver for MSM8909
Date: Wed, 29 Jun 2022 11:42:44 +0200 [thread overview]
Message-ID: <56976554-ddfe-d1d8-59a0-d7a7dd17f375@linaro.org> (raw)
In-Reply-To: <20220628145502.4158234-3-stephan.gerhold@kernkonzept.com>
On 28/06/2022 16:55, Stephan Gerhold wrote:
> Make it possible to control pins using the TLMM block in the MSM8909 SoC
> by adding the necessary definitions for GPIOs, groups and functions.
>
> The driver is originally taken from the msm-4.9 release [1] from Qualcomm,
> but cleaned up significantly with several fixes and clarifications.
>
> [1]: https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LF.UM.8.7-22500-8x09.0/drivers/pinctrl/qcom/pinctrl-msm8909.c
>
> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
> ---
> drivers/pinctrl/qcom/Kconfig | 8 +
> drivers/pinctrl/qcom/Makefile | 1 +
> drivers/pinctrl/qcom/pinctrl-msm8909.c | 956 +++++++++++++++++++++++++
I did not validate actual numbers/pins, but the driver structure looks good.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-29 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:55 [PATCH 0/2] pinctrl: qcom: Add pinctrl driver for MSM8909 Stephan Gerhold
2022-06-28 14:55 ` [PATCH 1/2] dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm Stephan Gerhold
2022-06-29 9:38 ` Krzysztof Kozlowski
2022-06-29 11:37 ` Stephan Gerhold
2022-06-29 12:43 ` Krzysztof Kozlowski
2022-06-28 14:55 ` [PATCH 2/2] pinctrl: qcom: Add pinctrl driver for MSM8909 Stephan Gerhold
2022-06-29 9:42 ` Krzysztof Kozlowski [this message]
2022-07-11 8:28 ` [PATCH 0/2] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56976554-ddfe-d1d8-59a0-d7a7dd17f375@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).