From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2FF9C433EF for ; Wed, 29 Jun 2022 09:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232291AbiF2Jmw (ORCPT ); Wed, 29 Jun 2022 05:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233037AbiF2Jmv (ORCPT ); Wed, 29 Jun 2022 05:42:51 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4997C3CFD0 for ; Wed, 29 Jun 2022 02:42:49 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id z41so2822214ede.1 for ; Wed, 29 Jun 2022 02:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YkE3fq4zHHBIP0Wimmvx31H6GwCLnjd0b8nNId/pgAQ=; b=QuRfOCE+32quNyaAzH4XZ5+6NP0OeyICUyCahTtqC9SIuCwCWP+ls5rhSLzF25hQNm ZYevxOnvYEERu8IiOvxUlYOHzr57odhPKxK/z3sY656otVWjt+vBWYHXlHwu9jMKnLlR N+HaLV3qIjqG3gj6cKImr4DI4NBU1vl1NLZlYEl4YibDcIIRBLOIcQQo5lhXizZFgRAq V9uhHl/2s0xYHeeMpL5E7d4nr/VwWr5fYeCWDQOEk43J9iIBOqLlxR+ESH6BqDuO+eTE ZIAaLLPEM1/Znrk8kf36h/vKiBnfRQRk2FUkXONaI8u68LlcB42wQl8X1TuTlxgyutlO 0N+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YkE3fq4zHHBIP0Wimmvx31H6GwCLnjd0b8nNId/pgAQ=; b=zuYbiu7MSuq6tfV1DFvVi5IfiSHPzp7CnMOIs1hihwOPPxGJB56K5jueD++B1aQn8n kUj6u7v0khGJcHkj+jwxzKLbzZWX7ybw089yxDc/EkqKFNqWcEr2vdp9ARuy5+9Qotl3 3rWc7nBYYLj9s/KWUHmy65F89vqk7xRT/Vv1QoS3ZTroucr3o8zzIPlklBBHpmgH8qRJ iNFisBLkik7Y6o0VddwreYBdAb+YufClke8Vv2j9KE2LgbgFYzl/3ZIUtpV9HMJyCM5m TKkiol+0a5/WoKt2/DLIEVtLo/mwCEa7L1Va01/UjTky29uF/W/8qXrKNdO3rhrat+Cl gQ4g== X-Gm-Message-State: AJIora9MuzdznVycxc4pDd+CXE5Roz484jl3JSiaWRqvx7nmbCfSekU+ LlEBTnmIDCYS+aUc40Tcq+DCubn3sFRNDw== X-Google-Smtp-Source: AGRyM1th7zSm2UAkK9P7kdVf6GKnbozGBNJb2QDcxoG7pO6lf89xibAxe9obppcdSZpMv9MiCKSWJw== X-Received: by 2002:a05:6402:400c:b0:437:d11f:f7d3 with SMTP id d12-20020a056402400c00b00437d11ff7d3mr3110664eda.256.1656495767900; Wed, 29 Jun 2022 02:42:47 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id hx23-20020a170906847700b00722e84c3d44sm7467081ejc.118.2022.06.29.02.42.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 02:42:47 -0700 (PDT) Message-ID: <56976554-ddfe-d1d8-59a0-d7a7dd17f375@linaro.org> Date: Wed, 29 Jun 2022 11:42:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/2] pinctrl: qcom: Add pinctrl driver for MSM8909 Content-Language: en-US To: Stephan Gerhold , Linus Walleij Cc: Bjorn Andersson , Andy Gross , Rob Herring , Krzysztof Kozlowski , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org References: <20220628145502.4158234-1-stephan.gerhold@kernkonzept.com> <20220628145502.4158234-3-stephan.gerhold@kernkonzept.com> From: Krzysztof Kozlowski In-Reply-To: <20220628145502.4158234-3-stephan.gerhold@kernkonzept.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/06/2022 16:55, Stephan Gerhold wrote: > Make it possible to control pins using the TLMM block in the MSM8909 SoC > by adding the necessary definitions for GPIOs, groups and functions. > > The driver is originally taken from the msm-4.9 release [1] from Qualcomm, > but cleaned up significantly with several fixes and clarifications. > > [1]: https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LF.UM.8.7-22500-8x09.0/drivers/pinctrl/qcom/pinctrl-msm8909.c > > Signed-off-by: Stephan Gerhold > --- > drivers/pinctrl/qcom/Kconfig | 8 + > drivers/pinctrl/qcom/Makefile | 1 + > drivers/pinctrl/qcom/pinctrl-msm8909.c | 956 +++++++++++++++++++++++++ I did not validate actual numbers/pins, but the driver structure looks good. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof