* [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART
@ 2016-03-08 5:43 Christopher Covington
2016-03-08 14:51 ` Mark Langsdorf
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Covington @ 2016-03-08 5:43 UTC (permalink / raw)
To: Russell King, Greg Kroah-Hartman, Jiri Slaby, linux-serial,
linux-kernel
Cc: linux-arm-msm, Timur Tabi, Jon Masters, Mark Langsdorf,
Andre Przywara, Dave Martin, Aleksey Makarov,
Christopher Covington, Christopher Covington
From: Christopher Covington <christopher.covington@linaro.org>
Version 2 of the Server Base System Architecture (SBSA) describes the
Generic UART registers as 32 bits wide. At least one implementation, found
of the Qualcomm Technologies QDF2432, only supports 32 bit accesses. While
other implementations may also support smaller sized accesses, simply use
32 bit accesses all the time for the SBSA UART for simple, broad,
compatibility.
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
drivers/tty/serial/amba-pl011.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index c0da0cc..ffb5eb8 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -121,6 +121,7 @@ static struct vendor_data vendor_arm = {
static struct vendor_data vendor_sbsa = {
.reg_offset = pl011_std_offsets,
+ .access_32b = true,
.oversampling = false,
.dma_threshold = false,
.cts_event_workaround = false,
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART
2016-03-08 5:43 [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington
@ 2016-03-08 14:51 ` Mark Langsdorf
0 siblings, 0 replies; 2+ messages in thread
From: Mark Langsdorf @ 2016-03-08 14:51 UTC (permalink / raw)
To: Christopher Covington, Russell King, Greg Kroah-Hartman,
Jiri Slaby, linux-serial, linux-kernel
Cc: linux-arm-msm, Timur Tabi, Jon Masters, Andre Przywara,
Dave Martin, Aleksey Makarov, Christopher Covington
On 03/07/2016 11:43 PM, Christopher Covington wrote:
> From: Christopher Covington <christopher.covington@linaro.org>
>
> Version 2 of the Server Base System Architecture (SBSA) describes the
> Generic UART registers as 32 bits wide. At least one implementation, found
> of the Qualcomm Technologies QDF2432, only supports 32 bit accesses. While
> other implementations may also support smaller sized accesses, simply use
> 32 bit accesses all the time for the SBSA UART for simple, broad,
> compatibility.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
I can boot the v4.5-rc7 on my QDF2432 platform with this patch,
and could not otherwise.
Tested-by: Mark Langsdorf <mlangsdo@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-08 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 5:43 [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington
2016-03-08 14:51 ` Mark Langsdorf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).