Re: [PATCH] arm64: dts: qcom: sm8650: add iris DT node

[Neil Armstrong <neil.armstrong@linaro.org>]

On 19/04/2025 01:05, Dmitry Baryshkov wrote:
> On Fri, Apr 18, 2025 at 03:20:35PM +0200, Neil Armstrong wrote:
>> Add DT entries for the sm8650 iris decoder.
>>
>> Since the firmware is required to be signed, only enable
>> on Qualcomm development boards where the firmware is
>> available.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8650-hdk.dts |  5 ++
>>   arch/arm64/boot/dts/qcom/sm8650-mtp.dts |  5 ++
>>   arch/arm64/boot/dts/qcom/sm8650-qrd.dts |  5 ++
> 
> I'd say that these are 4 commits.

I could make 10 and still be coherent, but do we really need 4 here ?

> 
>>   arch/arm64/boot/dts/qcom/sm8650.dtsi    | 94 +++++++++++++++++++++++++++++++++
>>   4 files changed, 109 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
>> index d0912735b54e5090f9f213c2c9341e03effbbbff..69db971d9d2d32cdee7bb1c3093c7849b94798a0 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
>> @@ -894,6 +894,11 @@ &ipa {
>>   	status = "okay";
>>   };
>>   
>> +&iris {
>> +	firmware-name = "qcom/vpu/vpu33_p4.mbn";
> 
> You shouldn't need to specify this, it matches the default one.

Hmm ok

> 
>> +	status = "okay";
>> +};
>> +
>>   &gpu {
>>   	status = "okay";
>>   
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
>> index 76ef43c10f77d8329ccf0a05c9d590a46372315f..04108235d9bc6f977e9cf1b887b0c89537723387 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
>> @@ -585,6 +585,11 @@ vreg_l7n_3p3: ldo7 {
>>   	};
>>   };
>>   
>> +&iris {
>> +	firmware-name = "qcom/vpu/vpu33_p4.mbn";
>> +	status = "okay";
>> +};
>> +
>>   &lpass_tlmm {
>>   	spkr_1_sd_n_active: spkr-1-sd-n-active-state {
>>   		pins = "gpio21";
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
>> index 71033fba21b56bc63620dca3e453c14191739675..58bdc6619ac55eda122f3fe6e680e0e61967d019 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
>> @@ -824,6 +824,11 @@ &ipa {
>>   	status = "okay";
>>   };
>>   
>> +&iris {
>> +	firmware-name = "qcom/vpu/vpu33_p4.mbn";
>> +	status = "okay";
>> +};
>> +
>>   &gpu {
>>   	status = "okay";
>>   
> 

Thanks,
Neil