From: Dan Carpenter <dan.carpenter@linaro.org>
To: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>,
Carl Vanderlip <quic_carlv@quicinc.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/5] accel/qaic: tighten bounds checking in encode_message()
Date: Tue, 4 Jul 2023 11:48:38 +0300 [thread overview]
Message-ID: <571cd06a-c488-4e46-af0d-183943fbbd7d@kadam.mountain> (raw)
In-Reply-To: <5fecc4c3-7a99-4329-d56c-b6a4f56c990c@quicinc.com>
On Tue, Jul 04, 2023 at 12:04:01PM +0530, Pranjal Ramajor Asha Kanojiya wrote:
> > > -??????? if (user_len + trans_hdr->len > user_msg->len) {
> > > +??????? if (trans_hdr->len < sizeof(trans_hdr) ||
> > > +??????????? size_add(user_len, trans_hdr->len) > user_msg->len) {
> Since the size of characters per line is 100 now. Can we rearrange this if
> condition and have them in one line. Similarity at other places in this
> patch series.
Style is subjective so I can't say for sure that my style is better but
obviously it is. ;) Those are two separate conditions so I put them on
two lines. If it were something very related like if (x < 0 || x >= 10)
then I would have put it on one line.
regards,
dan carpenter
next prev parent reply other threads:[~2023-07-04 8:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:21 [PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode Dan Carpenter
2023-06-21 7:21 ` [PATCH 1/5] accel/qaic: tighten bounds checking in encode_message() Dan Carpenter
2023-06-22 11:24 ` Pranjal Ramajor Asha Kanojiya
2023-06-22 11:43 ` Dan Carpenter
2023-06-22 11:54 ` Dan Carpenter
2023-07-04 6:27 ` Pranjal Ramajor Asha Kanojiya
2023-07-04 6:34 ` Pranjal Ramajor Asha Kanojiya
2023-07-04 8:48 ` Dan Carpenter [this message]
2023-07-04 8:38 ` Dan Carpenter
2023-07-04 9:48 ` Pranjal Ramajor Asha Kanojiya
2023-07-04 9:58 ` Dan Carpenter
2023-07-07 18:29 ` Jeffrey Hugo
2023-06-21 7:21 ` [PATCH 2/5] accel/qaic: tighten bounds checking in decode_message() Dan Carpenter
2023-07-04 6:30 ` Pranjal Ramajor Asha Kanojiya
2023-07-07 18:43 ` Jeffrey Hugo
2023-06-21 7:22 ` [PATCH 3/5] accel/qaic: Add consistent integer overflow checks Dan Carpenter
2023-07-07 18:51 ` Jeffrey Hugo
2023-07-08 5:06 ` Pranjal Ramajor Asha Kanojiya
2023-06-21 7:22 ` [PATCH 4/5] accel/qaic: move and expand integer overflow checks for map_user_pages() Dan Carpenter
2023-07-07 19:16 ` Jeffrey Hugo
2023-06-21 7:22 ` [PATCH 5/5] accel/qaic: Fix a leak in map_user_pages() Dan Carpenter
2023-07-07 19:24 ` Jeffrey Hugo
2023-07-08 4:44 ` Pranjal Ramajor Asha Kanojiya
2023-06-22 2:53 ` [PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode Jeffrey Hugo
2023-06-22 10:22 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-07-11 6:05 [PATCH 0/5 v2] " Dan Carpenter
2023-07-11 6:06 ` [PATCH 1/5] accel/qaic: tighten bounds checking in encode_message() Dan Carpenter
2023-07-11 6:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571cd06a-c488-4e46-af0d-183943fbbd7d@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox