From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Date: Thu, 2 Jun 2016 15:57:42 +0100 Message-ID: <57504966.6030800@linaro.org> References: <1464862996-3147-1-git-send-email-srinivas.kandagatla@linaro.org> <1464862996-3147-4-git-send-email-srinivas.kandagatla@linaro.org> <20160602144932.GK2282@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:38080 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932128AbcFBO5p (ORCPT ); Thu, 2 Jun 2016 10:57:45 -0400 Received: by mail-wm0-f54.google.com with SMTP id a20so70870469wma.1 for ; Thu, 02 Jun 2016 07:57:45 -0700 (PDT) In-Reply-To: <20160602144932.GK2282@sirena.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Brown Cc: bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, Liam Girdwood , linux-arm-msm@vger.kernel.org On 02/06/16 15:49, Mark Brown wrote: > On Thu, Jun 02, 2016 at 11:23:16AM +0100, Srinivas Kandagatla wrote: >> This patch converts a fixed voltage pm8941 lnldo to a single step >> linear range regulator, so that we could use the same list_volatage >> callback without BUG_ON from regulator core. > > Why is this better than using a separate set of ops for the driver? Am ok either way, it would be just few more lines for separate set of ops. --srini