From: Krzysztof Kozlowski <krzk@kernel.org>
To: Maya Matuszczyk <maccraft123mc@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987
Date: Sun, 22 Dec 2024 07:40:42 +0100 [thread overview]
Message-ID: <57515c0f-caa0-4651-96cf-dde75a13937f@kernel.org> (raw)
In-Reply-To: <tma7q7lfskdr7myfoeene7o27g7nhc5ca66kpmnqvgksv5oxqv@ziefqqp5khic>
On 22/12/2024 07:33, Krzysztof Kozlowski wrote:
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,x1e-it8987-ec
>
> That's not a SoC, so I don't understand:
> 1. referring to the SoC,
> 2. Having this alone and as fallback.
>
> It does not look like you tested the bindings, at least after quick
> look. Please run 'make dt_binding_check' (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
BTW, for sure Qualcomm did not develop/create it8987, so it cannot be
used here. Come with specific compatible for this given, one product:
embedded controller on one Lenovo laptop and use it also as filename.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-22 6:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 20:08 [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987 Maya Matuszczyk
2024-12-19 20:08 ` [PATCH v2 2/3] platform: arm64: Add driver for EC found in most X1E laptops Maya Matuszczyk
2024-12-19 20:43 ` Bryan O'Donoghue
2024-12-19 20:58 ` Maya Matuszczyk
2024-12-20 11:50 ` Aiqun(Maria) Yu
2024-12-20 12:14 ` Maya Matuszczyk
2024-12-22 6:56 ` Dmitry Baryshkov
2024-12-22 6:35 ` Krzysztof Kozlowski
2024-12-20 19:01 ` Stephan Gerhold
2024-12-22 6:34 ` Krzysztof Kozlowski
2024-12-19 20:08 ` [PATCH v2 3/3] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add the EC Maya Matuszczyk
2024-12-20 11:52 ` Aiqun(Maria) Yu
2024-12-20 12:10 ` Konrad Dybcio
2024-12-19 23:40 ` [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987 Rob Herring (Arm)
2024-12-20 18:05 ` Stephan Gerhold
[not found] ` <CAO_MupJ7JtXNgGyXcxGa+EGAvsu-yG0O6MgneGUBdCEgKNG+MA@mail.gmail.com>
2024-12-20 18:24 ` Stephan Gerhold
2024-12-22 14:40 ` Krzysztof Kozlowski
2024-12-22 15:07 ` Maya Matuszczyk
2024-12-23 14:25 ` Krzysztof Kozlowski
2024-12-30 2:45 ` Aiqun(Maria) Yu
2025-01-14 10:23 ` Aiqun(Maria) Yu
2024-12-22 6:33 ` Krzysztof Kozlowski
2024-12-22 6:40 ` Krzysztof Kozlowski [this message]
2024-12-22 7:55 ` Maya Matuszczyk
2024-12-22 9:40 ` Maya Matuszczyk
2024-12-22 14:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57515c0f-caa0-4651-96cf-dde75a13937f@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox