From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 3/5] ARM: dts: add L2CC and RPM with regulators for MSM8660 Date: Wed, 15 Jun 2016 17:57:40 -0700 Message-ID: <5761F984.2060305@codeaurora.org> References: <1465918259-11138-1-git-send-email-linus.walleij@linaro.org> <1465918259-11138-4-git-send-email-linus.walleij@linaro.org> <20160614185517.GG28218@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48175 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932078AbcFPA5m (ORCPT ); Wed, 15 Jun 2016 20:57:42 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , linux-soc@vger.kernel.org, Andy Gross , Bjorn Andersson , David Brown On 06/15/2016 06:16 AM, Linus Walleij wrote: > On Tue, Jun 14, 2016 at 8:55 PM, Stephen Boyd wrote: > >> >> Just leave these out? RPM shouldn't be touching s0 or s1. > Really? The msm-3.4 tree does: > > /* RPM early regulator constraints */ > static struct rpm_regulator_init_data > rpm_regulator_early_init_data[] = { > /* ID a_on pd ss min_uV max_uV init_ip freq */ > RPM_SMPS(PM8058_S0, 0, 1, 1, 500000, 1325000, SMPS_HMIN, 1p60), > RPM_SMPS(PM8058_S1, 0, 1, 1, 500000, 1250000, SMPS_HMIN, 1p60), > > Are you sure you don't mean s0+s1 on PM8901 (which I left out)? > Ah yes, I meant pm8901. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project